PHP 8.4 Support #80
Merged
PHP 8.4 Support #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composer and PHPUnit run without errors or warnings now.
Contributor
Author
|
@kayw-geek You can run the workflow again now. 🤞 |
Contributor
Author
|
Sorry for the back-and forth; I wish there was an easier way to test these. |
Contributor
Author
|
So close! |
Collaborator
|
Hi @garrettw, Thank you for your PR and the extensive changes you've made to support 8.4. The new tag 12.0.1 has been released. There might be some bugs, but that's okay - we'll fix them gradually in future updates. |
Contributor
Author
|
@kayw-geek Happy to help! Now I just need to upgrade my copy and try it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70
Closes #78
In order to support PHP 8.4, some nested dependencies of abandoned packages we directly depend on needed to be updated. And since we won't be able to update the abandoned packages...
For now, the quickest and easiest solution in my view was to copy into this repo the source code of only the abandoned deps that must be updated for compatibility.
Additionally, I edited the composer configs and PHPUnit configs/tests of each subpackage as needed to ensure those sub-packages can be developed here if necessary.
The intent here is for the abandoned packages to eventually be replaced by their suggested replacements, but that would be a lot more work, so this should be fine as a stopgap measure.