make use of naming helper (#211)

Author: TomasVotruba

src/Rules/Doctrine/NoDocumentMockingRule.php

@@ -11,6 +11,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use Symplify\PHPStanRules\Enum\RuleIdentifier\PHPUnitRuleIdentifier;
+use Symplify\PHPStanRules\Helper\NamingHelper;
 
 /**
  * @implements Rule<MethodCall>
@@ -36,12 +37,7 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
-        if (! $node->name instanceof Identifier) {
-            return [];
-        }
-
-        $methodName = $node->name->toString();
-        if ($methodName !== 'createMock') {
+        if (! NamingHelper::isName($node->name, 'createMock')) {
             return [];
         }
 

src/Rules/Doctrine/NoGetRepositoryOnServiceRepositoryEntityRule.php

@@ -19,6 +19,7 @@
 use Symplify\PHPStanRules\Enum\DoctrineClass;
 use Symplify\PHPStanRules\Enum\RuleIdentifier\DoctrineRuleIdentifier;
 use Symplify\PHPStanRules\Enum\TestClassName;
+use Symplify\PHPStanRules\Helper\NamingHelper;
 
 /**
  * @implements Rule<MethodCall>
@@ -51,7 +52,7 @@ public function getNodeType(): string
      */
     public function processNode(Node $node, Scope $scope): array
     {
-        if (! $node->name instanceof Identifier || $node->name->toString() !== 'getRepository') {
+        if (! NamingHelper::isName($node->name, 'getRepository')) {
             return [];
         }
 

src/Rules/Doctrine/NoGetRepositoryOutsideServiceRule.php

@@ -6,11 +6,11 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
-use PhpParser\Node\Identifier;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use Symplify\PHPStanRules\Enum\RuleIdentifier\DoctrineRuleIdentifier;
+use Symplify\PHPStanRules\Helper\NamingHelper;
 
 /**
  * @see \Symplify\PHPStanRules\Tests\Rules\Doctrine\NoGetRepositoryOutsideServiceRule\NoGetRepositoryOutsideServiceRuleTest
@@ -34,11 +34,7 @@ public function getNodeType(): string
      */
     public function processNode(Node $node, Scope $scope): array
     {
-        if (! $node->name instanceof Identifier) {
-            return [];
-        }
-
-        if ($node->name->toString() !== 'getRepository') {
+        if (! NamingHelper::isName($node->name, 'getRepository')) {
             return [];
         }
 

src/Rules/Doctrine/RequireQueryBuilderOnRepositoryRule.php

@@ -6,13 +6,13 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
-use PhpParser\Node\Identifier;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\ObjectType;
 use Symplify\PHPStanRules\Enum\DoctrineClass;
 use Symplify\PHPStanRules\Enum\RuleIdentifier\DoctrineRuleIdentifier;
+use Symplify\PHPStanRules\Helper\NamingHelper;
 
 /**
  * @implements Rule<MethodCall>
@@ -34,11 +34,7 @@ public function getNodeType(): string
      */
     public function processNode(Node $node, Scope $scope): array
     {
-        if (! $node->name instanceof Identifier) {
-            return [];
-        }
-
-        if ($node->name->toString() !== 'createQueryBuilder') {
+        if (! NamingHelper::isName($node->name, 'createQueryBuilder')) {
             return [];
         }
 

src/Rules/NoValueObjectInServiceConstructorRule.php

@@ -11,6 +11,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use Symplify\PHPStanRules\Enum\RuleIdentifier;
+use Symplify\PHPStanRules\Helper\NamingHelper;
 
 /**
  * @implements Rule<ClassMethod>
@@ -27,7 +28,7 @@ public function getNodeType(): string
      */
     public function processNode(Node $node, Scope $scope): array
     {
-        if ($node->name->toString() !== '__construct') {
+        if (! NamingHelper::isName($node->name, '__construct')) {
             return [];
         }
 

src/Rules/PHPUnit/NoAssertFuncCallInTestsRule.php

@@ -4,12 +4,12 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\FuncCall;
-use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\IdentifierRuleError;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use Symplify\PHPStanRules\Enum\RuleIdentifier\PHPUnitRuleIdentifier;
+use Symplify\PHPStanRules\Helper\NamingHelper;
 
 /**
  * @implements Rule<FuncCall>
@@ -38,11 +38,7 @@ public function getNodeType(): string
      */
     public function processNode(Node $node, Scope $scope): array
     {
-        if (! $node->name instanceof Name) {
-            return [];
-        }
-
-        if ($node->name->toString() !== 'assert') {
+        if (! NamingHelper::isName($node->name, 'assert')) {
             return [];
         }
 

src/Rules/Rector/NoInstanceOfStaticReflectionRule.php

@@ -15,6 +15,7 @@
 use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\Type;
 use Symplify\PHPStanRules\Enum\RuleIdentifier\RectorRuleIdentifier;
+use Symplify\PHPStanRules\Helper\NamingHelper;
 use Symplify\PHPStanRules\TypeAnalyzer\RectorAllowedAutoloadedTypeAnalyzer;
 
 /**
@@ -65,11 +66,7 @@ private function resolveExprStaticType(FuncCall|Instanceof_ $node, Scope $scope)
             return $this->resolveInstanceOfType($node, $scope);
         }
 
-        if (! $node->name instanceof Name) {
-            return null;
-        }
-
-        if ($node->name->toString() !== 'is_a') {
+        if (! NamingHelper::isName($node->name, 'is_a')) {
             return null;
         }
 

src/Rules/Symfony/ConfigClosure/ServicesExcludedDirectoryMustExistRule.php

@@ -11,7 +11,6 @@
 use PhpParser\Node\Expr\BinaryOp\Concat;
 use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\Expr\MethodCall;
-use PhpParser\Node\Identifier;
 use PhpParser\Node\Scalar\MagicConst\Dir;
 use PhpParser\Node\Scalar\String_;
 use PhpParser\NodeFinder;
@@ -20,6 +19,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use Symplify\PHPStanRules\Enum\RuleIdentifier\SymfonyRuleIdentifier;
+use Symplify\PHPStanRules\Helper\NamingHelper;
 use Symplify\PHPStanRules\Symfony\NodeAnalyzer\SymfonyClosureDetector;
 
 /**
@@ -138,11 +138,7 @@ private function resolveExcludeMethodCalls(Closure $closure): array
                 return false;
             }
 
-            if (! $node->name instanceof Identifier) {
-                return false;
-            }
-
-            return $node->name->toString() === 'exclude';
+            return NamingHelper::isName($node->name, 'exclude');
         });
 
         /** @var MethodCall[] $methodCalls */

src/Rules/Symfony/NoFindTaggedServiceIdsCallRule.php

@@ -12,6 +12,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use Symplify\PHPStanRules\Enum\RuleIdentifier\SymfonyRuleIdentifier;
+use Symplify\PHPStanRules\Helper\NamingHelper;
 
 /**
  * @implements Rule<MethodCall>
@@ -34,11 +35,7 @@ public function getNodeType(): string
      */
     public function processNode(Node $node, Scope $scope): array
     {
-        if (! $node->name instanceof Identifier) {
-            return [];
-        }
-
-        if ($node->name->toString() !== 'findTaggedServiceIds') {
+        if (! NamingHelper::isName($node->name, 'findTaggedServiceIds')) {
             return [];
         }
 

src/Rules/Symfony/NoRoutingPrefixRule.php

@@ -15,6 +15,7 @@
 use PHPStan\Type\ObjectType;
 use Symplify\PHPStanRules\Enum\RuleIdentifier\SymfonyRuleIdentifier;
 use Symplify\PHPStanRules\Enum\SymfonyClass;
+use Symplify\PHPStanRules\Helper\NamingHelper;
 
 /**
  * @implements Rule<MethodCall>
@@ -39,11 +40,7 @@ public function getNodeType(): string
      */
     public function processNode(Node $node, Scope $scope): array
     {
-        if (! $node->name instanceof Identifier) {
-            return [];
-        }
-
-        if ($node->name->toString() !== 'prefix') {
+        if (! NamingHelper::isName($node->name, 'prefix')) {
             return [];
         }