skip wildcards in StringFileAbsolutePathExistsRule (#194)

Author: TomasVotruba

src/Rules/StringFileAbsolutePathExistsRule.php

@@ -60,6 +60,11 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
+        // probably glob or wildcard, cannot be checked
+        if (str_contains($stringValue, '*')) {
+            return [];
+        }
+
         $absoluteFilePath = $this->getAbsoluteFilePath($scope, $stringValue);
         if (file_exists($absoluteFilePath)) {
             return [];

tests/Rules/StringFileAbsolutePathExistsRule/Fixture/SkipClosure.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Symplify\PHPStanRules\Tests\Rules\StringFileAbsolutePathExistsRule\Fixture;
+
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+
+return function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->load('App\\', __DIR__ . '/../src/*Repository.php');
+};

tests/Rules/StringFileAbsolutePathExistsRule/Fixture/SkipMasks.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Symplify\PHPStanRules\Tests\Rules\StringFileAbsolutePathExistsRule\Fixture;
+
+final class SkipMasks
+{
+    public function go()
+    {
+        return glob(__DIR__  . '/some_file/*');
+    }
+}

tests/Rules/StringFileAbsolutePathExistsRule/StringFileAbsolutePathExistsRuleTest.php

@@ -28,6 +28,8 @@ public static function provideData(): Iterator
 
         yield [__DIR__ . '/Fixture/SkipReferenceToExistingFile.php', []];
         yield [__DIR__ . '/Fixture/SkipNestedConcats.php', []];
+        yield [__DIR__ . '/Fixture/SkipMasks.php', []];
+        yield [__DIR__ . '/Fixture/SkipClosure.php', []];
     }
 
     protected function getRule(): Rule