fix rector rule test

Author: TomasVotruba

composer.json

@@ -18,7 +18,8 @@
         "rector/rector": "^2.0",
         "phpstan/extension-installer": "^1.4",
         "symplify/phpstan-extensions": "^12.0",
-        "tomasvotruba/unused-public": "^2.0"
+        "tomasvotruba/unused-public": "^2.0",
+        "tomasvotruba/type-coverage": "^2.0"
     },
     "autoload": {
         "psr-4": {

phpstan.neon

@@ -28,10 +28,10 @@ parameters:
         properties: true
         constants: true
 
-    # type_coverage:
-    #     return: 99
-    #     param: 99
-    #     property: 99
+    type_coverage:
+        return: 99
+        param: 99
+        property: 99
 
     ignoreErrors:
         # needless generics

phpunit.xml

@@ -1,5 +1,11 @@
 <?xml version="1.0"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="vendor/autoload.php" colors="true" xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd" cacheDirectory=".phpunit.cache">
+<phpunit
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    bootstrap="vendor/autoload.php"
+    colors="true"
+    xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
+    displayDetailsOnIncompleteTests="true"
+    cacheDirectory=".phpunit.cache">
     <testsuite name="all">
         <directory>tests</directory>
         <exclude>tests/Rules/ClassNameRespectsParentSuffixRule/Fixture/</exclude>

phpunit.xml.bak

@@ -4,6 +4,8 @@
 
 namespace Symplify\PHPStanRules\Composer;
 
+use Symplify\PHPStanRules\FileSystem\FileSystem;
+
 final class ComposerAutoloadResolver
 {
     /**
@@ -20,7 +22,7 @@ public function getPsr4Autoload(): array
             return [];
         }
 
-        $fileContent = \Symplify\PHPStanRules\FileSystem\FileSystem::read(self::COMPOSER_JSON_FILE);
+        $fileContent = FileSystem::read(self::COMPOSER_JSON_FILE);
         $composerJsonContent = json_decode($fileContent, true, 512, JSON_THROW_ON_ERROR);
 
         $autoloadPsr4 = $composerJsonContent['autoload']['psr-4'] ?? [];

src/Composer/ComposerAutoloadResolver.php

@@ -40,7 +40,7 @@ private function removeAbstractInterfacePrefixSuffix(string $parentType): string
         }
 
         if (\str_starts_with($parentType, 'Abstract')) {
-            return substr($parentType, (int) strlen('Abstract'));
+            return substr($parentType, strlen('Abstract'));
         }
 
         return $parentType;

src/Naming/ClassToSuffixResolver.php

@@ -14,6 +14,7 @@
 use PHPStan\Reflection\MethodReflection;
 use ReflectionClass;
 use ReflectionMethod;
+use Symplify\PHPStanRules\FileSystem\FileSystem;
 use Symplify\PHPStanRules\NodeFinder\TypeAwareNodeFinder;
 use Throwable;
 
@@ -77,7 +78,7 @@ private function parseFilenameToClass(string $fileName): ClassLike|null
         }
 
         try {
-            $stmts = $this->parser->parse(\Symplify\PHPStanRules\FileSystem\FileSystem::read($fileName));
+            $stmts = $this->parser->parse(FileSystem::read($fileName));
             if (! is_array($stmts)) {
                 return null;
             }

src/Reflection/ReflectionParser.php

@@ -4,7 +4,6 @@
 
 namespace Symplify\PHPStanRules\Rules;
 
-use Nette\Utils\Strings;
 use PhpParser\Comment\Doc;
 use PhpParser\Node;
 use PhpParser\Node\Scalar\String_;
@@ -89,7 +88,8 @@ private function isNonSingleCharRegexPattern(string $value): bool
             return false;
         }
 
-        $lastChar = Strings::substring($patternWithoutModifiers, -1, 1);
+        $lastChar = substr($patternWithoutModifiers, -1, 1);
+
         // this is probably a regex
         return $firstChar === $lastChar;
     }

src/Rules/AnnotateRegexClassConstWithRegexLinkRule.php

@@ -18,6 +18,7 @@
 use SplFileInfo;
 use Symplify\PHPStanRules\Enum\RuleIdentifier;
 use Symplify\PHPStanRules\Exception\ShouldNotHappenException;
+use Symplify\PHPStanRules\FileSystem\FileSystem;
 
 /**
  * @see \Symplify\PHPStanRules\Tests\Rules\Rector\PhpUpgradeDowngradeRegisteredInSetRule\PhpUpgradeDowngradeRegisteredInSetRuleTest
@@ -57,7 +58,7 @@ public function processNode(Node $node, Scope $scope): array
             return [];
         }
 
-        $configContent = \Symplify\PHPStanRules\FileSystem\FileSystem::read($configFilePath);
+        $configContent = FileSystem::read($configFilePath);
 
         // is rule registered?
         if (str_contains($configContent, $className)) {

src/Rules/Rector/PhpUpgradeDowngradeRegisteredInSetRule.php

@@ -5,16 +5,10 @@
 namespace Symplify\PHPStanRules\Tests\Rules\Rector\PhpUpgradeDowngradeRegisteredInSetRule\Fixture\DowngradePhp80;
 
 use PhpParser\Node;
-use Rector\Contract\Rector\RectorInterface;
 use Rector\Rector\AbstractRector;
-use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
-final class SomePhpFeature2Rector extends AbstractRector implements RectorInterface
+final class SomePhpFeature2Rector extends AbstractRector
 {
-    public function getRuleDefinition(): RuleDefinition
-    {
-    }
-
     public function getNodeTypes(): array
     {
         return [];