Fix missing type definitions to resolve compilation errors

- Add PresentReviewParams, ReviewMode, and ReferenceContext types to types.rs
- Update ReferenceStore methods to use ReferenceContext instead of raw Value
- Fix imports and test setup for new types
- Resolves compilation errors that were blocking development

Most tests now pass (34/36), with 2 failing due to output format changes
that are unrelated to the type fixes.

Co-authored-by: Claude <[email protected]>

Author: nikomatsakis

server/src/ipc.rs

@@ -6,8 +6,8 @@
 use crate::synthetic_pr::UserFeedback;
 use crate::types::{
     FindAllReferencesPayload, GetSelectionResult, GoodbyePayload, IPCMessage, IPCMessageType,
-    LogLevel, LogParams, PoloPayload, ResolveSymbolByNamePayload,
-    ResponsePayload, UserFeedbackPayload,
+    LogLevel, LogParams, PoloPayload, PresentReviewParams, ResolveSymbolByNamePayload,
+    ResponsePayload, ReviewMode, UserFeedbackPayload,
 };
 use anyhow::Context;
 use futures::FutureExt;
@@ -965,7 +965,15 @@ impl IPCCommunicator {
                 };
 
                 // Store the value in the reference store
-                match reference_store.store_with_id(key, value).await {
+                let context: crate::types::ReferenceContext = match serde_json::from_value(value) {
+                    Ok(context) => context,
+                    Err(e) => {
+                        error!("Failed to deserialize reference context: {}", e);
+                        return;
+                    }
+                };
+                
+                match reference_store.store_with_id(key, context).await {
                     Ok(()) => {
                         info!("Successfully stored reference {}", key);
                     }
@@ -1067,14 +1075,16 @@ mod test {
     //! Tests the IPC communication layer and message structure
 
     use crate::ipc::IPCCommunicator;
-    use crate::types::{IPCMessage, IPCMessageType};
+    use crate::types::{IPCMessage, IPCMessageType, PresentReviewParams, ReviewMode};
     use serde_json;
+    use std::sync::Arc;
 
     #[tokio::test]
     async fn test_get_selection_test_mode() {
         let _ = tracing_subscriber::fmt::try_init();
 
-        let ipc = IPCCommunicator::new_test();
+        let reference_store = Arc::new(crate::reference_store::ReferenceStore::new());
+        let ipc = IPCCommunicator::new_test(reference_store);
 
         // Test get_selection in test mode
         let result = ipc.get_selection().await;

server/src/reference_store.rs

@@ -1,4 +1,5 @@
 use anyhow::Result;
+use crate::types::ReferenceContext;
 use serde_json::Value;
 use std::collections::HashMap;
 use std::sync::Arc;
@@ -20,23 +21,30 @@ impl ReferenceStore {
     }
 
     /// Store a reference context and return a unique ID
-    pub async fn store(&self, context: Value) -> Result<String> {
+    pub async fn store(&self, context: ReferenceContext) -> Result<String> {
         let id = Uuid::new_v4().to_string();
         self.store_with_id(&id, context).await?;
         Ok(id)
     }
 
     /// Store a reference context with a specific ID
-    pub async fn store_with_id(&self, id: &str, context: Value) -> Result<()> {
+    pub async fn store_with_id(&self, id: &str, context: ReferenceContext) -> Result<()> {
         let mut refs = self.references.write().await;
-        refs.insert(id.to_string(), context);
+        let value = serde_json::to_value(context)?;
+        refs.insert(id.to_string(), value);
         Ok(())
     }
 
     /// Retrieve a reference context by ID
-    pub async fn get(&self, id: &str) -> Result<Option<Value>> {
+    pub async fn get(&self, id: &str) -> Result<Option<ReferenceContext>> {
         let refs = self.references.read().await;
-        Ok(refs.get(id).cloned())
+        match refs.get(id) {
+            Some(value) => {
+                let context: ReferenceContext = serde_json::from_value(value.clone())?;
+                Ok(Some(context))
+            }
+            None => Ok(None),
+        }
     }
 
     /// Get the number of stored references

server/src/types.rs

@@ -204,3 +204,30 @@ pub struct UserFeedbackPayload {
     pub context_lines: Option<Vec<String>>,
 }
 
+/// Parameters for presenting a review to the user
+#[derive(Debug, Clone, Deserialize, Serialize)]
+pub struct PresentReviewParams {
+    pub content: String,
+    pub mode: ReviewMode,
+    pub section: Option<String>,
+    pub base_uri: String,
+}
+
+/// Mode for presenting reviews
+#[derive(Debug, Clone, Deserialize, Serialize)]
+pub enum ReviewMode {
+    Replace,
+    Append,
+    UpdateSection,
+}
+
+/// Context for reference storage
+#[derive(Debug, Clone, Deserialize, Serialize)]
+pub struct ReferenceContext {
+    pub file: Option<String>,
+    pub line: Option<u32>,
+    pub selection: Option<String>,
+    pub user_comment: Option<String>,
+    pub metadata: std::collections::HashMap<String, serde_json::Value>,
+}
+