feat(vscode): local distribution + approval routing fix #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElizACP was being spawned directly with 'symposium-acp-agent eliza', bypassing the Symposium conductor/proxy chain (Sparkle, Ferris, etc). Now symposium builtins are spawned as: symposium-acp-agent --trace-dir ... -- symposium-acp-agent eliza This routes them through the conductor like any other agent. Co-authored-by: Claude <[email protected]>
Adds LocalDistribution for running local binaries as agents, mirroring MCP server config pattern with command, args, and env fields. Local distribution takes priority over other distribution types. Co-authored-by: Claude <[email protected]>
Previously approval requests were always sent to the first tab, which broke multi-tab scenarios. Now looks up the tab whose config matches the requesting agent's agentId. Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small improvements:
Local distribution type for agents
Adds
LocalDistributionfor running local binaries as agents, mirroring the MCP server config pattern:{ "symposium.agents": { "my-local-agent": { "name": "My Local Agent", "distribution": { "local": { "command": "/path/to/binary", "args": ["--mode", "acp"], "env": { "DEBUG": "true" } } } } } }Local distribution takes priority over other distribution types.
Fix approval request routing
Previously approval requests were always sent to the first tab, which broke multi-tab scenarios (approval dialog wouldn't appear on the correct tab). Now looks up the tab whose config matches the requesting agent's agentId.
Co-authored-by: Claude [email protected]