This repository is currently being migrated. It's locked while the migration is in progress.
Small bug fixes #36
Open
Small bug fixes #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaymanWilliams
commented
Nov 30, 2023
| # MAGIC * The Gradient Webhook has been configured | ||
| # MAGIC * The Databricks Job has been Gradient enabled | ||
| # MAGIC | ||
| # MAGIC When bypassing the Gradient Webhook with AWS, the cluster attached to this notebook must have an instance_arn with describe_instances and describe_volumes permissions. When bypassing the Gradient Webhook with Azure, the following environment variables must be set with the correct values: "AZURE_TENANT_ID", "AZURE_SUBSCRIPTION_ID", "AZURE_CLIENT_SECRET", "AZURE_CLIENT_ID" |
Contributor
Author
There was a problem hiding this comment.
Just added this in case it's unclear what customers would need to do to bypass the webhook. I'm fine with taking it out if bypassing the webhook is supposed to be a complete edge case
CaymanWilliams
commented
Nov 30, 2023
| # MAGIC | ||
| # MAGIC When bypassing the Gradient Webhook with AWS, the cluster attached to this notebook must have an instance_arn with describe_instances and describe_volumes permissions. When bypassing the Gradient Webhook with Azure, the following environment variables must be set with the correct values: "AZURE_TENANT_ID", "AZURE_SUBSCRIPTION_ID", "AZURE_CLIENT_SECRET", "AZURE_CLIENT_ID" | ||
| # MAGIC | ||
| # MAGIC This job will configure all runs to execute using ON DEMAND nodes only. The orginal settings will be restored after training is complete. |
Contributor
Author
There was a problem hiding this comment.
Is this true? Are the settings ever restored? (Supposed to be looking at the line under the highlighted one)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple small edits to make compatible with python >=3.7 and only making the access_report necessary when bypassing the webhook.