Skip to content

Conversation

@singhals
Copy link
Contributor

Summary

please add a few lines to give the reviewer context on the changes

Checklist

Before formally opening this PR, please adhere to the following standards:

  • Branch/PR names begin with the related Jira ticket id (ie PROD-31) for Jira integration
  • File names are lower_snake_case
  • Relevant unit tests have been added or not applicable
  • Relevant documentation has been added or not applicable
  • Mark yourself as the assignee (makes it easier to scan the PR list)

Related Jira Ticket (add id)

Add any relevant testing examples or screenshots.

@singhals singhals changed the base branch from main to Pydantic-upgrade April 23, 2024 21:33
@singhals singhals changed the base branch from Pydantic-upgrade to main April 23, 2024 21:34
logger.error("Unable to apply gradient configuration to Databricks run submit tasks")


def build_app_id(task_id: str, app_id: str):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def build_app_id(task_id: str, app_id: str):
def build_app_id(task_id: str, app_id: str) -> str:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants