Add additional check to avoid cast issues in PdfNumber when accessing bookmarks #2490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional check to avoid > type 'PdfNull' is not a subtype of type 'PdfNumber?' in type cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I ran into the following runtime error when accessing a bookmark destination (from a namedDestination):
Unfortunately I cann't share the original PDF (probably malformed), but it opens correctly on other viewers.
This PR fixes the issue by adding a simple defensive type check before casting the destination value to PdfNumber, preventing invalid casts when the destination contains PdfNull (or anything else)