Skip to content

Application got crash when load the PullToRefresh and Expander controls within different layouts. #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

SanjaySF4372
Copy link
Collaborator

@SanjaySF4372 SanjaySF4372 commented Jul 24, 2025

Bug Description
1.Application got crash when load the PullToRefresh controls within different layouts.
2.When setting the PullTorefresh API in GlobalStyles exception occurs.
3. Application crashes when setting the API's using Global Styling in Accordion and Expander control. Adding the Unit test cases for the Expander and Accordion.

Root Cause
1.The Layouts will have infinite width or height when it is measured in the control.So,it returns the infinite value because of that exception occurs.
2.When setting the PullTorefresh API in GlobalStyles the ProgressCircleView is null it is not loaded.So,that issue exception occurs in the layouts.
3.When setting the API in global styling ,while loading it calls the its API property changed methods first so in that items were not loaded .So items become null then the exception occurs.

Is Breaking issue?
No

Solution description
1.Manually added the height as 300 if the height is infinite and added width as 300 if the width is infinite for windows.For other than windows added the DeviceDisplay width and DeviceDisplay height for it.
2.Added the null check condition ProgressCircleView is not null for the API PropertyChanged methods.
3.Added the condition if the IsViewLoaded is false then it should return in the propertychanged methods.

Output screenshots
Windows:

Screen.Recording.2025-07-15.114653.mp4
Screen.Recording.2025-07-23.144743.mp4

Android:

Screen.Recording.2025-07-23.145601.mp4

Unit test case Image:
image

Areas affected and ensured
No areas were affected.

Test cases
Tested the Styles cases in all platforms.
Tested the Layout cases in all platforms.

Does it have any known issues?
No

MR CheckList

  • Have you ensured in iOS, Android, WinUI, and macOS(if supported)? Yes
  • If there is any API change, did you get approval from PLO through JIRA Tasks? No
  • Is there any existing behavior change of other features due to this code change? No
  • Did you perform the automation / manual testing against your fix?
  • Did you record this case in the unit test or UI test?
  • Have you suppressed any warning or binding errors? No
  • Is there any existing behavior change of other features due to this code change? No
  • Does it need localization? If so did you ensure the cases mentioned in this link? No
  • Whether the new APIs and its comments are added as per standard? No
  • Did you ensure the cases mentioned in this link? Not Applicable
  • Did you ensure the fix (if applicable) met accessibility requirements? Not Applicable
  • If you added any interaction related code, have you used touch and gesture APIs from core project? Not Applicable
  • Does it contain code that reflects any internal framework API? Not Applicable
  • Did you ensure the cases mentioned in this link? Not Applicable
  • Did you ensure RTL? Not Applicable
  • Did you test the memory leak with the fix? Not Applicable
  • Did you ensure the ? Check this link to know more about performance optimization and how to automate? Not Applicable
  • If you use a third-party package, did you get approval to use it? If not, please get approval before merging. Not Applicable

@RasikaPalanisamy
Copy link
Collaborator

This is fine.

Copy link
Collaborator

@FarjanaParveen FarjanaParveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants