Fixed the issue of Horizontal axis labels skipped despite available space. #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulAndersonS
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description
X-axis labels were inconsistently skipped during chart rendering, even when sufficient space was available. This led to a poor user experience, especially in scenarios where label readability was critical.
Bug Report : #241
Root Cause of the Issue
The static spacing factor used in the interval count calculation did not account for label rotation. As a result, the algorithm underestimated the number of labels that could be displayed, leading to unnecessary skipping.
Description of Change
The interval count calculation logic was updated to compute the spacing factor based on the label rotation angle. This ensures that the available space is utilized more effectively, and the correct number of intervals is generated for the X-axis.
Screenshots
Before:
After:
Test cases