Resolved the selectionchanged issue for SfTabView.#252
Merged
PaulAndersonS merged 1 commit intomainfrom Aug 25, 2025
Merged
Conversation
KishoreJey
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a touch event handling issue in the SfTabView component for iOS that was preventing proper selection change functionality. The issue was caused by improper handling of touch event propagation within the UI hierarchy.
- Fixed bracket placement in the
ShouldHandleTapmethod to ensure proper code execution flow - Corrected conditional logic structure to allow all relevant views to process touch events
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
PaulAndersonS
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause of the Issue
The root cause of the issue was an improper handling of touch event propagation within the UI hierarchy of the iOS implementation, specifically in relation to how input views were being tested for touch interactions. By not allowing all relevant views to respond to touches, the user experience was negatively affected.
Description of Change
The bug was resolved by modifying the conditions properly in the SfHorizontalContent.iOS.cs file. The adjusted implementation returns the root view directly without further checks, ensuring that any view can process touch events effectively. This allows taps to register as intended for item selection.
Issues Fixed
Fixes: #251