Skip to content

chore: remove removed debugging endpoint, toggle #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2025
Merged

chore: remove removed debugging endpoint, toggle #949

merged 2 commits into from
Aug 10, 2025

Conversation

calmh
Copy link
Member

@calmh calmh commented Aug 10, 2025

No description provided.

@calmh calmh changed the base branch from main to v2 August 10, 2025 06:35
calmh added a commit to syncthing/syncthing that referenced this pull request Aug 10, 2025
This removes the `debugging` bool under GUI configuration, and two no
longer relevant development endpoints: `httpmetrics` (which I can't
imagine anyone using for anything -- if we need such metrics today, the
right place is the Prometheus exported metrics) and the `peerCompletion`
endpoint (previously used by integration tests).

The debugging bool initially enabled just those two endpoints, which are
not for end users. Then we added profiling and support bundles, which
are very useful indeed for end users to access, and they were hidden
behind the same debug flag. I don't see any reason for keeping that flag
now that these methods are more generally useful.

syncthing/docs#949
@calmh calmh merged commit 29c4b36 into v2 Aug 10, 2025
5 checks passed
@calmh calmh deleted the jb/lessdebug branch August 10, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant