-
Notifications
You must be signed in to change notification settings - Fork 1
Biometrics & Pin on Launch Setup #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/build.gradle.kts # gradle/libs.versions.toml
Currently only affects implementation for biometrics, but it helps wire up the logic and will be needed for actual pin logic as well.
Scripts can call `AuthenticationCallback.onAuthenticationSucceeded`, which is why we need to secure against such attacks.
jvsena42
reviewed
Apr 21, 2025
jvsena42
reviewed
Apr 21, 2025
jvsena42
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIGMA Design
Biometrics & Pin on Launch Setup
Allows user to set PIN and toggle requiring it on launch. Also, on top of PIN, biometrics can be used.
onAuthenticationSucceededhack scriptingPreviews
Flow to enable & unlock
flowEnablePinBio.mp4
Flow when biometrics are disabled on device
flowBioNotSupported.mp4
Still a lot of implementation needed to cover all cases and mirror the React Native functionality, but this PR is setting up a good base for next PRs to build on it with more granular progress.