-
Notifications
You must be signed in to change notification settings - Fork 1
Implement tag feature in the EditInvoiceScreen #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I notice some state bugs in EditInvoiceScreen. I'll fix then in other PR |
…composable is active
Keep screen on and set brightness to max on QR code Screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice implementation! 🎉
I found a few small fixes for the tags implementation that need to be addressed.
I didn't add comments for the stat-related bugs in the EditInvoiceScreen, but we should fix those quite soon IMHO.
Main issue I found related to activity tags on received invoice is:
- when I receive payment on an invoice with a tag,
- then go to All Activity > tap
#to filter by tags - 🔴 I can't see the new tag(s), ie. tags added on the last paid invoice
- 🟠 If I restart the app then I see those
- 🟢 this is fixed after applying the suggestions from the review comments, in my tests
Wait for node start to execute lightning requests
|
Thanks for the great review!
Agree, I tried to fix it in this PR but I realized this state is tricky and would take more time to think in a good solution, and I'd like to merge this branch as soon as possible to avoid conflicts, so I create #123 I'll fix it after #124 because I've been losing some minutes waiting for the node restarts every time I close the app by accident |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the fixes 🥇
Ready and merged 🚀
FIGMA
Implement tag feature in the EditInvoiceScreen
Related to #50
receive_tag.mp4
(The freezing is because of the breakpoints in debug mode)