Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Apr 28, 2025

FIGMA

Implement tag feature in the EditInvoiceScreen

  • Layout
  • Navigation
  • Persist tag
  • Search tag
  • Clean all tags logic
  • Periodic clean unused tags
  • Attatch tag to invoice

Related to #50

receive_tag.mp4

(The freezing is because of the breakpoints in debug mode)

@jvsena42 jvsena42 self-assigned this Apr 28, 2025
@jvsena42 jvsena42 changed the title Feat/tags edit invoice Implement tag feature in the EditInvoiceScreen Apr 28, 2025
Base automatically changed from refactor/lightning-repository to master April 28, 2025 17:37
@jvsena42
Copy link
Member Author

jvsena42 commented May 1, 2025

I notice some state bugs in EditInvoiceScreen. I'll fix then in other PR

@jvsena42 jvsena42 marked this pull request as ready for review May 1, 2025 12:18
@jvsena42 jvsena42 requested a review from ovitrif May 1, 2025 12:18
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice implementation! 🎉

I found a few small fixes for the tags implementation that need to be addressed.

I didn't add comments for the stat-related bugs in the EditInvoiceScreen, but we should fix those quite soon IMHO.


Main issue I found related to activity tags on received invoice is:

  • when I receive payment on an invoice with a tag,
  • then go to All Activity > tap # to filter by tags
  • 🔴 I can't see the new tag(s), ie. tags added on the last paid invoice
  • 🟠 If I restart the app then I see those
  • 🟢 this is fixed after applying the suggestions from the review comments, in my tests

@jvsena42
Copy link
Member Author

jvsena42 commented May 2, 2025

Thanks for the great review!

I didn't add comments for the stat-related bugs in the EditInvoiceScreen, but we should fix those quite soon IMHO.

Agree, I tried to fix it in this PR but I realized this state is tricky and would take more time to think in a good solution, and I'd like to merge this branch as soon as possible to avoid conflicts, so I create #123

I'll fix it after #124 because I've been losing some minutes waiting for the node restarts every time I close the app by accident

@jvsena42 jvsena42 requested a review from ovitrif May 2, 2025 11:51
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the fixes 🥇
Ready and merged 🚀

@ovitrif ovitrif merged commit 44bfcbd into master May 2, 2025
1 check passed
@ovitrif ovitrif deleted the feat/tags-edit-invoice branch May 2, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants