-
Notifications
You must be signed in to change notification settings - Fork 1
LNURL Pay and Lightning Address #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
jvsena42
reviewed
Jul 23, 2025
jvsena42
reviewed
Jul 23, 2025
jvsena42
approved these changes
Jul 23, 2025
Member
jvsena42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean refactor!
It would be good to add the QA notes to the readme
Collaborator
Author
Thanks, added ref to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #202
FIGMA: Amount Screen | Confirm Screen
This PR re-implements LNURL Pay and lightning address handling.
Changes
Scanner.LnurlAddresshandlingQA Notes
bech32 lnurl
Env.kt, changeElectrumServers.REGTESTtodocker-compose.ymltohttp://__YOUR_NETWORK_IP__:3000docker compose up --build./bitcoin-cli mine 101./bitcoin-cli send./bitcoin-cli mine 1http://localhost:3000/healthlnd_info.urisarray, replace127.0.0.1with__YOUR_NETWORK_IP__and paste into app, then complete the flow./bitcoin-cli mine 3http://localhost:3000/generate/payhttp://localhost:3000/generate/pay?minSendable=10000&maxSendable=10000lightning address
ngrok http 3000DOMAINindocker-compose.ymlto__NGROK_URL__docker compose downif runningdocker compose up --buildhttp://localhost:3000/.well-known/lnurlp/aliceTests + Regressions
Previews
bech32.mp4
address.mp4
fixedAmountAndQuickpay.mp4