Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Jul 24, 2025

Closes #137 Related to #229

Description

Fixes the LSP channel size calculation

  • Simplify lspBalance calculation
  • Removes limit based on user onChain balance
  • Collect LSP values from viewmodel

Will be implemented in the next PRs

  • Layout fix for small screens
  • Error message improvements
  • Improvement on max amount button logic
  • Layout logic cleanup
  • Unit tests

Preview

Android Logs

2025-07-28 07:24:44.645 12684-12772 APP                     to.bitkit.dev                        I  INFOℹ️: Sending 51170 sats to bcrt1qvr6guch7pkgwhhz7kthvdghfdgy79urrcw746n with satsPerVByte=1 [LightningService.kt:412]
2025-07-28 07:24:45.387 12684-12684 APP                     to.bitkit.dev                        D  DEBUG: Started to watch order '7ad5c80b-01b7-4328-967a-7223b6f61e09' - TransferViewModel [TransferViewModel.kt:99]

Blocktant logs

:information_source: info: Created order 7ad5c80b-01b7-4328-967a-7223b6f61e09
lspBalanceSat=100000, clientBalanceSat=50000, source=bitkit-android, discountCode=undefined

QA Notes

Reference

@jvsena42 jvsena42 self-assigned this Jul 24, 2025
@jvsena42
Copy link
Member Author

The order was created with success, but Blocktank still hasn't approved

https://synonymworkspace.slack.com/archives/C02FYR1JSNS/p1753698281354129

@jvsena42 jvsena42 marked this pull request as ready for review July 28, 2025 10:50
@jvsena42 jvsena42 requested a review from ovitrif July 28, 2025 10:50
@jvsena42 jvsena42 enabled auto-merge July 28, 2025 11:08
@ovitrif
Copy link
Collaborator

ovitrif commented Jul 28, 2025

The order was created with success, but Blocktank still hasn't approved

https://synonymworkspace.slack.com/archives/C02FYR1JSNS/p1753698281354129

The original bug was affecting pre-order creation logic, so it's not a blocker to merge, though would've loved to test e2e

Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easier to reason about!

added 2 comments about code formatting preference, if you agree feel free to update in next PR 👍🏻

@jvsena42 jvsena42 merged commit 93a5473 into master Jul 28, 2025
3 checks passed
@jvsena42 jvsena42 deleted the fix/transfer-spending-limit branch July 28, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Transfer to Spending issue on wallets of 490.000+ onchain sats

3 participants