Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jvsena42
commented
Jul 30, 2025
# Conflicts: # app/src/main/java/to/bitkit/services/CoreService.kt
ovitrif
reviewed
Jul 31, 2025
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
Looks good and works great!
Added a comment about code cleanup and one for the todo comments
Tested (new wallet)
- send onchain
- transfer to spending
ovitrif
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #229 , #243 , #149
This PR caches payment metadata to update the Activity info
Description
Preview
lightning.mp4
transfer.mp4
on_chain.mp4
rbf.mp4
CPFP.mp4
QA Notes
This solution doesn't cover received transactions
Tests