Skip to content

Integrate VSS rust client bindings for backups#270

Merged
jvsena42 merged 11 commits intomasterfrom
feat/vss-rust-client-ffi
Jul 31, 2025
Merged

Integrate VSS rust client bindings for backups#270
jvsena42 merged 11 commits intomasterfrom
feat/vss-rust-client-ffi

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Jul 31, 2025

This PR replaces the old custom backup client written in Kotlin by integrating with the rust ffi bindings for the vss-rust-client exposed thru vss-rust-client-ffi.

Description

  • Replace old backup client with new client integrating the rust bindings
  • Improve logs for backup and restore
  • fix: prevent entering a transfer amount higher than max limit
  • fix: typo in readme
  • Update ldk-node and use new bolt11 payment prop for activity

Note Restore of old user data won't work, not because of incompatibilities, but because I changed the backup category keys passed to VSS, from lowercase to UPPERCASE. This shouldn't be an issue, ldk-node (thus node and wallet state) backups still work.

Preview

n/a - no major UI changes

QA Notes

Tests

  1. Restore existing wallet with previous backup data
  2. New wallet > change settings and widgets > wipe > restore
  3. Transfer: try to enter an amount above max limit
  4. Activity Explore: verify bolt11 for sent and received LN payments

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@ovitrif ovitrif requested a review from jvsena42 July 31, 2025 11:59
@ovitrif ovitrif self-assigned this Jul 31, 2025
@ovitrif ovitrif requested a review from jvsena42 July 31, 2025 13:56
Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

  • Create fresh wallet
  • transfer
  • cjit
  • send lightning
  • send onCHain
  • restore

@jvsena42 jvsena42 merged commit 6a4bc1d into master Jul 31, 2025
3 checks passed
@jvsena42 jvsena42 deleted the feat/vss-rust-client-ffi branch July 31, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments