Integrate VSS rust client bindings for backups#270
Merged
Conversation
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
jvsena42
reviewed
Jul 31, 2025
jvsena42
reviewed
Jul 31, 2025
jvsena42
approved these changes
Jul 31, 2025
Member
jvsena42
left a comment
There was a problem hiding this comment.
Tested
- Create fresh wallet
- transfer
- cjit
- send lightning
- send onCHain
- restore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the old custom backup client written in Kotlin by integrating with the rust ffi bindings for the vss-rust-client exposed thru vss-rust-client-ffi.
Description
Note Restore of old user data won't work, not because of incompatibilities, but because I changed the backup category keys passed to VSS, from lowercase to UPPERCASE. This shouldn't be an issue, ldk-node (thus node and wallet state) backups still work.
Preview
n/a - no major UI changes
QA Notes
Tests