-
Notifications
You must be signed in to change notification settings - Fork 1
E2E workflow #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E workflow #271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a comprehensive GitHub Actions workflow for end-to-end testing that builds the app with E2E configuration and runs automated tests against a regtest environment. The workflow can be triggered manually or automatically on pull requests.
- Adds a complete e2e.yml workflow file with build and test jobs
- Updates Electrum server host configuration from
127.0.0.1to10.0.2.2for Android emulator compatibility - Implements APK build, regtest environment setup, and automated test execution with artifact collection on failure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/e2e.yml | New comprehensive E2E workflow with build job, test environment setup, and automated testing |
| app/src/main/java/to/bitkit/env/Env.kt | Updates E2E Electrum server host to work with Android emulator networking |
Comments suppressed due to low confidence (1)
.github/workflows/e2e.yml:86
- The actions/cache@v3 action is outdated. Consider upgrading to actions/cache@v4 for better performance and security updates.
uses: actions/cache@v3
jvsena42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding a filter to skip Draft pull request to save resources
e81065d to
7566a75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👏🏻
I like the adb reverse fix 👏🏻 , with it, connecting to the LND peer from docker container should also work smooth. (not sure if it works tho'
7566a75 to
b466ed9
Compare
It worked indeed! 🎉 |
Done. 👍 |
Description
This PR introduces a GitHub Actions workflow for running end-to-end tests.
It can be triggered manually from the Actions UI or automatically on
pull_request.For now, it includes only a single test case:
Onboarding - Can start onboarding— mainly due to the current lack oftestIDs in the app.The e2e workflow:
To make the test work in the Android emulator environment I changed the Electrum server host to10.0.2.2(which maps to the host machine's127.0.0.1in the emulator).It turns out that using
127.0.0.1didn’t work after all in the GitHub Actions environment.See: 53ba0a1 @ovitrif 🤷
Worked with b466ed9. 🎉
Future PRs will expand test coverage as more
testIDsare added.Preview
QA Notes
Workflow run manually several times to make sure it is stable.
See: https://github.com/synonymdev/bitkit-android/actions/workflows/e2e.yml