Skip to content

Validation min transfer amount #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvsena42 merged 8 commits into from
Aug 4, 2025
Merged

Validation min transfer amount #277

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
013fd73
feat: display min amount error
jvsena42 Aug 3, 2025
20c047e
feat: get dust limit
jvsena42 Aug 3, 2025
f54f52a
feat: fee validation
jvsena42 Aug 3, 2025
402d17d
feat: display fee
jvsena42 Aug 4, 2025
3c47352
feat: loading
jvsena42 Aug 4, 2025
58e94b1
Merge branch 'master' into fix/min-transfer-validation
jvsena42 Aug 4, 2025
7b62296
feat: add the dust limit check
jvsena42 Aug 4, 2025
c2cc15a
fix: typo
jvsena42 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions app/src/main/java/to/bitkit/viewmodels/TransferViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import org.lightningdevkit.ldknode.ChannelDetails
import to.bitkit.R
import to.bitkit.data.CacheStore
import to.bitkit.data.SettingsStore
import to.bitkit.env.Env
import to.bitkit.models.TransactionSpeed
import to.bitkit.repositories.BlocktankRepo
import to.bitkit.repositories.CurrencyRepo
Expand Down Expand Up @@ -71,6 +72,7 @@ class TransferViewModel @Inject constructor(
val transferEffects = MutableSharedFlow<TransferEffect>()
fun setTransferEffect(effect: TransferEffect) = viewModelScope.launch { transferEffects.emit(effect) }
var retryTimes = 0
var maxLspFee = 0uL

// region Spending

Expand Down Expand Up @@ -119,10 +121,23 @@ class TransferViewModel @Inject constructor(
)
return
}
viewModelScope.launch {
_spendingUiState.update { it.copy(isLoading = true) }

_spendingUiState.update { it.copy(isLoading = true) }
val minAmount = getMinAmountToPurchase()
if (_spendingUiState.value.satsAmount < minAmount) {
setTransferEffect(
TransferEffect.ToastError(
title = context.getString(R.string.lightning__spending_amount__error_min__title),
description = context.getString(
R.string.lightning__spending_amount__error_min__description
).replace("{amount}", "$minAmount"),
)
)
_spendingUiState.update { it.copy(overrideSats = minAmount, isLoading = false) }
return@launch
}

viewModelScope.launch {
blocktankRepo.createOrder(_spendingUiState.value.satsAmount.toULong())
.onSuccess { order ->
onOrderCreated(order)
Expand Down Expand Up @@ -228,6 +243,11 @@ class TransferViewModel @Inject constructor(
}
}

private suspend fun getMinAmountToPurchase(): Long {
val fee = lightningRepo.calculateTotalFee(_spendingUiState.value.satsAmount.toULong()).getOrNull() ?: 0u
return max((fee + maxLspFee).toLong(), Env.TransactionDefaults.dustLimit.toLong())
}

private fun onOrderCreated(order: IBtOrder) {
_spendingUiState.update { it.copy(order = order, isAdvanced = false, defaultOrder = null) }
setTransferEffect(TransferEffect.OnOrderCreated)
Expand All @@ -246,7 +266,7 @@ class TransferViewModel @Inject constructor(
receivingBalanceSats = _transferValues.value.maxLspBalance
).onSuccess { estimate ->
retryTimes = 0
val maxLspFee = estimate.feeSat
maxLspFee = estimate.feeSat

// Calculate the available balance to send after LSP fee
val balanceAfterLspFee = availableAmount - maxLspFee
Expand Down