-
Notifications
You must be signed in to change notification settings - Fork 1
chore: use vss-client from github packages #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
00e6369 to
11d0395
Compare
|
Reminder: to not merge this PR before the one for bitkit-core |
11d0395 to
3c526b3
Compare
3c526b3 to
5cee828
Compare
5cee828 to
7f3145b
Compare
jvsena42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only missing the updates from #294
7f3145b to
b5a736c
Compare
Fixed and updated the gradle scripts to work as expected by allowing also the option via Welcoming another review 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything under The reason your GIT sees the files now is because they were not included in GIT before, and now with no more |
jvsena42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
- Sync the project with
local.propertiescredentials - Deleted autogerenated old files
- Run the project

Related:
Description
This PR updates the build config to consume the
vss-clientdependency from GitHub packages instead of bundling the bindings in the app's code.Important Check the bindings README, you will need to Setup your GitHub credentials in order to be able to build locally sourcing the dependency from the GitHub packages maven repository.
Preview
n/aQA Notes
Test that building succeeds and the new app runs without errors (existing wallet), then remove a sugestion card and check logcat to confirm the backup was successful.