Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Aug 12, 2025

Related:

Description

This PR updates the build config to consume the vss-client dependency from GitHub packages instead of bundling the bindings in the app's code.

Important Check the bindings README, you will need to Setup your GitHub credentials in order to be able to build locally sourcing the dependency from the GitHub packages maven repository.

Preview

n/a

QA Notes

Test that building succeeds and the new app runs without errors (existing wallet), then remove a sugestion card and check logcat to confirm the backup was successful.

@ovitrif ovitrif self-assigned this Aug 12, 2025
@ovitrif ovitrif force-pushed the chore/vss-gh-package branch from 00e6369 to 11d0395 Compare August 14, 2025 15:40
@ovitrif ovitrif marked this pull request as ready for review August 14, 2025 16:23
@ovitrif ovitrif requested a review from jvsena42 August 14, 2025 16:23
@ovitrif ovitrif enabled auto-merge August 14, 2025 16:24
@ovitrif
Copy link
Collaborator Author

ovitrif commented Aug 14, 2025

Reminder: to not merge this PR before the one for bitkit-core

@ovitrif ovitrif force-pushed the chore/vss-gh-package branch from 11d0395 to 3c526b3 Compare August 14, 2025 16:48
@ovitrif ovitrif removed the request for review from jvsena42 August 14, 2025 16:58
@ovitrif ovitrif force-pushed the chore/vss-gh-package branch from 3c526b3 to 5cee828 Compare August 14, 2025 17:00
@ovitrif ovitrif requested a review from jvsena42 August 14, 2025 17:00
@ovitrif ovitrif force-pushed the chore/vss-gh-package branch from 5cee828 to 7f3145b Compare August 14, 2025 17:24
Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only missing the updates from #294

@ovitrif ovitrif force-pushed the chore/vss-gh-package branch from 7f3145b to b5a736c Compare August 18, 2025 09:57
@ovitrif ovitrif requested a review from jvsena42 August 18, 2025 09:57
@ovitrif
Copy link
Collaborator Author

ovitrif commented Aug 18, 2025

Only missing the updates from #294

Fixed and updated the gradle scripts to work as expected by allowing also the option via local.properties.

Welcoming another review 🙏🏻

Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got many libs/vss-client/buld/ autogenerated files in my git, I suppose this directory should be in .gitignore

image

@ovitrif
Copy link
Collaborator Author

ovitrif commented Aug 18, 2025

I got many libs/vss-client/buld/ autogenerated files in my git, I suppose this directory should be in .gitignore

Everything under libs/vss-client should be deleted, no need to ignore it anymore. The directory was listed in the nested .gitignore which got deleted when I removed the inner module. We don't need that module anymore, the app simply consumes the vss client as a dependency, like all other dependencies.

The reason your GIT sees the files now is because they were not included in GIT before, and now with no more .gitignore entry, they appear as if it's new code.

Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

  • Sync the project with local.properties credentials
  • Deleted autogerenated old files
  • Run the project

@ovitrif ovitrif merged commit 8b64ef1 into master Aug 18, 2025
5 checks passed
@ovitrif ovitrif deleted the chore/vss-gh-package branch August 18, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants