Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Aug 13, 2025

This PR adds testTags for most of the testID's used by the e2e tests from the react native repo.

Description

There is a markdown doc added in docs/e2e-test-ids.md for tracking and to provide an overview. Note that some of the testId's will not be added at all, because the features and their screens were descoped. For status overview on screens progress, consult the new doc in docs/screens-map.md.

Changes

  • feat: e2e test ids wip
  • feat: qr code text input for e2e tests
  • feat: backups status text for e2e tests
  • feat: boosted parents ui on activity explore screen
  • feat: polish activity tabs
  • feat: activity detail transfer status
  • fix: activity detail money texts
  • fix: nav to address screen onclick address in send confirm
  • fix: nav to amount screen onclick amount in send confirm
  • fix: disable swipe to hide balance in activity details
  • fix: home screen balance amounts preview
  • chore: add home empty state preview
  • refactor: extract all text styles
  • docs: e2e-test-ids.md doc for tracking testIds to testTags progress
  • docs: screens-map.md doc for mapping android screens to RN screens

Preview

Boosted Parents

parents

QA Notes

Tested for regressions:

  • send flow
  • wallet screens: home, spending, savings
  • activity screens: list, detail, explore

feat: e2e test ids
feat: polish activity tabs
fix: activity detail money texts
fix: nav to address screen onclick address in send confirm
fix: nav to amount screen onclick amount in send confirm
fix: disable swipe to hide balance in activity details
fix: home screen balance amounts preview
chore: add home empty state preview
# Conflicts:
#	app/src/main/java/to/bitkit/ui/screens/wallets/receive/EditInvoiceScreen.kt
#	app/src/main/java/to/bitkit/ui/screens/wallets/send/SendAmountScreen.kt
@ovitrif ovitrif self-assigned this Aug 13, 2025
@ovitrif ovitrif requested a review from jvsena42 August 13, 2025 21:02
@ovitrif ovitrif marked this pull request as draft August 14, 2025 08:42
@ovitrif
Copy link
Collaborator Author

ovitrif commented Aug 14, 2025

Drafted to add the rest of the testIds that can be added, since there's not that many remaining.

github-advanced-security[bot]

This comment was marked as outdated.

@ovitrif ovitrif marked this pull request as ready for review August 14, 2025 14:44
@jvsena42
Copy link
Member

jvsena42 commented Aug 14, 2025

Triggered the tests manually
CI
https://github.com/synonymdev/bitkit-android/actions/runs/16970751458

E2E
https://github.com/synonymdev/bitkit-android/actions/runs/16970994725

@jvsena42 jvsena42 merged commit 5484979 into master Aug 14, 2025
8 checks passed
@jvsena42 jvsena42 deleted the feat/e2e-test-tags branch August 14, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants