Progress cards #300
Merged
Progress cards #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
# Conflicts: # app/src/main/java/to/bitkit/models/Suggestion.kt # app/src/main/java/to/bitkit/ui/screens/wallets/HomeViewModel.kt
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
ovitrif
approved these changes
Aug 19, 2025
Collaborator
There was a problem hiding this comment.
LGMT 🎉
Tested
- new transfer to spending + mining & watching the card update on the Home screen.
Added comments for some cleanup suggestions but nothing blocking.
Mainly the comment about the e2e test id Suggestion-lightningSettingUp should be addresses ASAP in a new PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIGMA
Related to #149 , #243
Description
This PR implements the progress cards in the suggestion flow
Preview
tranfer_rn.mp4
transfer_android.webm
QA Notes
How to reproduce: