Make tagInputTestTag and addButtonTestTag visible #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/to/bitkit/ui/screens/wallets/activity/components/ActivityAddTagSheet.kt
Fixed
Show fixed
Hide fixed
jvsena42
requested changes
Aug 25, 2025
Member
jvsena42
left a comment
jvsena42
left a comment
There was a problem hiding this comment.
Only missing the lint update. On Windows or Linux you can do ctrl+alt+L
Member
|
Probably the component test tag was merged |
piotr-iohk
force-pushed
the
show_TagInput_test_tag
branch
from
7f1bea4 to
94b914c
Compare
jvsena42
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test tags (i.e.
resource-ids) where not visible in the add tag screen until explicitely adding.semantics { testTagsAsResourceId = true }in this particular component function, that is used on the screen. Probably this component not created/rendered from the main scope wheretestTagsAsResourceId = trueis set globally. Maybe there is a better way to do this, but this fixes the problem andresource-idis now rendered.Preview
QA Notes