Display the success screen in the send sheet #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Note, I believe the e2e tests fail because the branch is currently behind |
ovitrif
approved these changes
Sep 2, 2025
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
LGTM
Tested 2 scenarios:
- send lightning 🟢
- send quickpay 🟢
Found 2 non-blocking bugs, can be fixed in future PR's:
- I can navigate back from the success screen, and upon 2 swipe-back gestures I landed on a broken send review/confirm screen
- After quickpay, the amount I seen in the sheet was ₿1 instead of ₿1500
Member
Author
Fixed in #341 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #318 (comment)
Description
This PR decouples the send success screen from the generic transactions sheet and displays it in the payment sheet
Preview
onchain-and-lightning.mp4
prefilled.mp4
quickpay.mp4
QA Notes
Tested: