Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Aug 29, 2025

Related to #268
FIGMA

Description

This PR removes the "Require pin on idle" feature
Slack thread

Preview

removed-idle.mp4

QA Notes

Tested:

  • On old install -> Enable Require pin on idle" and pin -> Install this version -> Wait 90 second in iddle -> shouldn,'t require pin
  • On fresh install -> Enable pin -> Wait 90 second in iddle -> shouldn,'t require pin

@jvsena42 jvsena42 self-assigned this Aug 29, 2025
@jvsena42 jvsena42 requested a review from ovitrif August 29, 2025 11:19
@jvsena42 jvsena42 enabled auto-merge September 1, 2025 15:26
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jvsena42

Wasn't this feature supposed to be changed into a different implementation?

I still see the feature on iOS and it works as such:

When switching to another app (ie. Bitkit app gets backgrounded), then returning to Bitkit, pin is required to be re-entered.

AFAIK we should do the same instead of removing the feature altogether.

@jvsena42 jvsena42 marked this pull request as draft September 2, 2025 14:09
auto-merge was automatically disabled September 2, 2025 14:09

Pull request was converted to draft

@jvsena42 jvsena42 closed this in #345 Sep 4, 2025
@ovitrif ovitrif deleted the feat/remove-pin-idle branch September 4, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants