Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Sep 1, 2025

Related to #49

Description

  • The Event.PaymentSuccessful doesn't return the amount sent, so as a temporary solution, the app can get it from the activity list
  • Use sendLightning data to display the success screen with the correct amount
  • Save the payment hash in processedPayments so it doesn't display the same success sheet twice
  • reset processedPayments on next payment

Preview

ln-send-sheet.mp4

QA Notes

Tested:

  • Send an LN payment -> Success -> Display success screen
  • Wait for Event.PaymentSuccessful -> Should not retrigger the success screen if already displayed

@jvsena42 jvsena42 self-assigned this Sep 1, 2025
@jvsena42 jvsena42 marked this pull request as draft September 1, 2025 11:01
@jvsena42 jvsena42 changed the title fix: Display LN amoun in send success sheet fix: Display LN amount in send success sheet Sep 1, 2025
@jvsena42 jvsena42 marked this pull request as ready for review September 1, 2025 11:49
@jvsena42 jvsena42 requested a review from ovitrif September 1, 2025 12:17
Base automatically changed from feat/send-success-screen to master September 2, 2025 09:37
@ovitrif ovitrif merged commit 187875d into master Sep 2, 2025
5 checks passed
@ovitrif ovitrif deleted the feat/ln-sent-value-sheet branch September 2, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants