Skip to content

Run tests and Lint on all PRs #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvsena42 merged 2 commits into from
Sep 1, 2025
Merged

Run tests and Lint on all PRs #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
816c076
ci: remove pull_request master filter from ci and lint
jvsena42 Sep 1, 2025
d18a0eb
test: update tests
jvsena42 Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on:
push:
branches: [ "master" ]
pull_request:
branches: [ "master" ]

workflow_dispatch:

Expand Down
1 change: 0 additions & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ on:
push:
branches: [ "master" ]
pull_request:
branches: [ "master" ]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down
6 changes: 6 additions & 0 deletions app/src/test/java/to/bitkit/repositories/ActivityRepoTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,12 @@ import org.mockito.kotlin.verify
import org.mockito.kotlin.whenever
import org.mockito.kotlin.wheneverBlocking
import to.bitkit.data.AppCacheData
import to.bitkit.data.AppDb
import to.bitkit.data.CacheStore
import to.bitkit.data.dto.PendingBoostActivity
import to.bitkit.services.CoreService
import to.bitkit.test.BaseUnitTest
import to.bitkit.utils.AddressChecker
import kotlin.test.assertEquals
import kotlin.test.assertFalse
import kotlin.test.assertNull
Expand All @@ -33,6 +35,8 @@ class ActivityRepoTest : BaseUnitTest() {
private val coreService: CoreService = mock()
private val lightningRepo: LightningRepo = mock()
private val cacheStore: CacheStore = mock()
private val addressChecker: AddressChecker = mock()
private val db: AppDb = mock()

private lateinit var sut: ActivityRepo

Expand Down Expand Up @@ -71,6 +75,8 @@ class ActivityRepoTest : BaseUnitTest() {
coreService = coreService,
lightningRepo = lightningRepo,
cacheStore = cacheStore,
addressChecker = addressChecker,
db = db
)
}

Expand Down