Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Sep 9, 2025

This PR refactors the receive amount screen in the CJIT flow to use the custom numeric keyboard and fixes a few other UI issues in the screen as well as on the edit invoice screen from the receive sheet.

Description

Changes:

  • feat(receive): change unit on amount click
  • fix(receive): push keyboard and buttons to the bottom
  • fix: send amount test tags in compose tests
  • feat(receive): use custom keyboard in cjit flow
  • refactor: add optional channelConfig param to openChannel

Preview

CJIT Amount Screen

Before After After - Small Screen

Edit Invoice Screen

Before After

QA Notes

Tests:

  • CJIT flow: brand-new wallet > receive > click switch > verify the keyboard on the cjit amount screen
  • Receive > edit > verify the edit invoice screen
    • tap amount text to show keyboard if hidden, then tap it again to switch units

@ovitrif ovitrif requested a review from jvsena42 September 9, 2025 20:34
@ovitrif ovitrif self-assigned this Sep 9, 2025
@ovitrif ovitrif changed the base branch from master to fix/send-scan-back-nav September 9, 2025 20:35
Base automatically changed from fix/send-scan-back-nav to master September 10, 2025 09:35

val minCjitSats by blocktank.minCjitSats.collectAsStateWithLifecycle()

ReceiveAmountContent(
Copy link
Member

@jvsena42 jvsena42 Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: Could implement SyncNodeView if the node is not running yet, it would simplify the onContinue logic

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have to think about it if it's a good idea in Receive - CJIT flow 🤔

@ovitrif ovitrif merged commit c06e612 into master Sep 10, 2025
10 of 11 checks passed
@ovitrif ovitrif deleted the fix/receive-keyboard branch September 10, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants