Skip to content

Improve geoblock validation for devices connected to external nodes #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jvsena42 wants to merge 8 commits into from
Closed

Improve geoblock validation for devices connected to external nodes #369

jvsena42 wants to merge 8 commits into from

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Sep 10, 2025 •
edited
Loading

Description

Geoblocked devices with external node connection should have generic LN features enabled but keep Blocktank related features blocked.

  • CheckGeoStatus renamed to isGeoBlocked

Lightning features:

  • Create Bolt11
  • Create CJIT (should block even with external node connection)
  • Request additional liquidity (should block even with external node connection)
  • Enable receiveOnSpendingBalance
  • Transfer from savings (should block even with external node connection)
  • onBoarding warning

Preview

QA Notes

mocked isGeoBlocked with hardcoded return

Tested:

  • Phone offline > should not block lightning
  • Geoblocked > Connected to external node > should allow lighting features
  • Geoblocked > NOT Connected to external node > should block lighting features

@jvsena42 jvsena42 self-assigned this Sep 10, 2025
@jvsena42 jvsena42 marked this pull request as ready for review September 11, 2025 12:28
@jvsena42 jvsena42 marked this pull request as draft September 11, 2025 12:28
@jvsena42 jvsena42 changed the title Fix/geoblock check external nodes Enable lightning for geoblocked devices with external nodes Sep 11, 2025
@jvsena42 jvsena42 changed the title Enable lightning for geoblocked devices with external nodes Improve geoblock validation for devices connected to external nodes Sep 11, 2025
@jvsena42 jvsena42 closed this Sep 11, 2025
@jvsena42 jvsena42 mentioned this pull request Sep 11, 2025
Merged
7 tasks
@jvsena42 jvsena42 deleted the fix/geoblock-check-external-nodes branch September 12, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jvsena42 jvsena42

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jvsena42 @piotr-iohk