Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Sep 11, 2025

Replaces #368

Description

  • Uses the cached lightning outbound as a fallback in the canSend method if the node is not running
  • Add loading state to continue button
  • Fix quickpay crash on payment failure
  • Skip sync time-out toast error messages
  • Set node notification importance as low

Preview

with_amount.mp4
quick_pay.mp4
ln_above_limit.mp4
zero_amount.mp4

QA Notes

  • No LN balance -> scan 0 amount uniffied invoice -> use only on-chain balance
  • With LN balance -> node syncing -> scan invoice with amount above available > error not enough balance
  • With LN balance -> node syncing -> scan 0 amount uniffied invoice > sync success -> enable both balances
  • With LN balance -> node synciing > scan 15 amount LN invoice -> sync success > display confirm screen
  • With LN balance -> node syncing -> scan invoice with amount above available-> quickpay enabled -> shouldn't pay
  • With LN balance -> node syncing -> scan 15 amount LN invoice -> quickpay enabled -> sync success -> should pay

@jvsena42 jvsena42 self-assigned this Sep 11, 2025
@jvsena42 jvsena42 changed the title fix: update send ui state only after node syncing fix: update send ui state after node sync Sep 11, 2025
@jvsena42 jvsena42 marked this pull request as ready for review September 12, 2025 11:13
@jvsena42 jvsena42 marked this pull request as draft September 12, 2025 11:23
@jvsena42 jvsena42 changed the title fix: update send ui state after node sync Used cached outbound as fallback when note is initializing Sep 12, 2025
@jvsena42 jvsena42 marked this pull request as ready for review September 12, 2025 13:03
@jvsena42 jvsena42 changed the title Used cached outbound as fallback when note is initializing Use cached outbound value as fallback when note is initializing Sep 12, 2025
@jvsena42 jvsena42 changed the title Use cached outbound value as fallback when note is initializing Use cached outbound value as fallback when node is initializing Sep 12, 2025
@jvsena42 jvsena42 requested a review from ovitrif September 12, 2025 14:22
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test results

  • No LN balance -> scan 0 amount uniffied invoice -> use only on-chain balance 🟢

  • With LN balance -> node syncing -> scan LN invoice with amount above available > error not enough balance 🟢

  • With LN balance -> node syncing -> scan 0 amount unified invoice > sync success -> enable both balances 🟢

  • With LN balance -> node syncing > scan 15 amount LN invoice -> sync success > display confirm screen 🟢

  • With LN balance -> node syncing -> scan invoice with amount above available-> quickpay enabled -> shouldn't pay 🟢

  • With LN balance -> node syncing -> scan 15 amount LN invoice -> quickpay enabled -> sync success -> should pay 🟠

    • fails for me with handler send error screen "node not setup" ✅ - still ok imho
    • it might've failed because of unexpected force-close

@ovitrif ovitrif merged commit ac9e5b3 into master Sep 12, 2025
7 checks passed
@ovitrif ovitrif deleted the fix/ln-balance-check-send branch September 12, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants