Primary, Secondary and Tertiary Buttons v59 #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the button styling to match the v59 design specifications from Figma. The changes introduce a new gradient-based visual style for primary buttons with shadow effects and refined color values across the theme.
Key changes:
- Updated gray color palette values for improved visual consistency
- Implemented new primary button styling with gradient backgrounds and shadow effects
- Replaced alpha-based disabled states with ColorFilter.tint for better color consistency
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Colors.kt | Updated gray color palette values and added Gray7 to support new design system |
| Modifiers.kt | Added primaryButtonStyle modifier with gradient backgrounds, shadow, and border effects |
| Button.kt | Refactored button components to use new styling system with ColorFilter instead of alpha for disabled states |
| ShowMnemonicScreen.kt | Removed hardcoded color parameter to use default button styling |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Collaborator
|
Fond this bug: Main Buttons are not always Full-Width
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIGMA
Description
This PR update the Primary, Secondary and Tertiary Buttons to v59. The other components. will be updated in other PR
Preview
QA Notes