-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Numpad v59 design #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Numpad component to match the v59 design specifications, focusing on visual styling and button layout improvements.
Key Changes:
- Refactored
NumberPadActionButtonto use Material3ButtonandOutlinedButtoncomponents with updated styling - Modified
ReceiveQrScreenbutton layout to use equal weight distribution across action buttons
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| NumberPadActionButton.kt | Replaced Surface-based button with Material3 Button/OutlinedButton, updated styling with new padding, height, and shape values |
| ReceiveQrScreen.kt | Added weight modifiers to buttons for equal distribution and wrapped copy button in Box |
b902fdc to
5095067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎨 Feature: Apply v59 Numpad Design
📝 Summary of Changes
This PR implements the design updates from v59 of the Bitkit Wallet, specifically applying the new aesthetic and layout to the Numpad component across all relevant screens.
🔗 Resources
🧪 QA Notes
Please verify the following:
Screens to Test:
SpendingAdvancedScreenSpendingAmountScreenExternalAmountScreenSendAmountScreen