-
Notifications
You must be signed in to change notification settings - Fork 1
fix: sync node and activities after a successful boost #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not ready for review yet, just testing E2E |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a race condition in the boost transaction flow that was causing random test failures in Android. When a transaction is boosted via RBF or CPFP, the app now properly syncs the Lightning node and activities before completing the operation, and immediately dismisses any existing toasts to prevent the "Transaction removed from mempool" toast from interfering with the "Boost successful" toast.
Key changes:
- Added Lightning node and activity sync after successful transaction boost
- Changed toast queue behavior to immediately dismiss current toast when showing a new one
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
BoostTransactionViewModel.kt |
Added sync calls for Lightning node and activities after successful boost to ensure UI state is current |
ToastQueueManager.kt |
Changed toast display logic to immediately dismiss current toast instead of queuing, matching iOS behavior |
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
Description
This test fails randomly in android for two reasons:
The iOS app don't fail because:
ios-rbf.mp4
Solution:
2.1. Cancel autohide like iOS (I'll try this solution first, but UX wise, I'd prefer the current logic of keeping the delay between toasts)
2.2. Or remove "Transaction removed from mempool" toast, because it doesn't exists in the figma
2.3 Or increase the timeout of the test action, or update it to dismiss the toasts
Preview
Screen_recording_20251214_085024.webm
QA Notes