Skip to content

Conversation

@jvsena42
Copy link
Member

Related to #692

This PR prevents error notifications from being shown to users when the WakeNodeWorker job is cancelled.

Description

  • Adds early return for CancellationException in WakeNodeWorker.doWork() failure handler
  • Skips setting error notification content when work is cancelled
  • Logs cancellation as debug instead of error since it's expected behavior

Preview

N/A - no UI changes

QA Notes

  1. Trigger a push notification that wakes the node
  2. Kill the app while the node is starting up
  3. Verify no "Lightning error" notification is shown to the user
  4. Check logs show "Work cancelled" debug message instead of error

@jvsena42 jvsena42 self-assigned this Jan 22, 2026
@claude
Copy link

claude bot commented Jan 22, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@ovitrif ovitrif self-requested a review January 22, 2026 18:18
Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ovitrif ovitrif enabled auto-merge January 22, 2026 18:18
@ovitrif ovitrif merged commit 7e8d259 into master Jan 22, 2026
21 of 23 checks passed
@ovitrif ovitrif deleted the fix/ignore-job-cancelation-on-notification branch January 22, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants