Skip to content

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Mar 26, 2025

Cache balance to disk and load it on startup, to avoid showing 0 balance for a brief moment on start.

startupWithCachedBalance.webm

@ovitrif ovitrif requested a review from jvsena42 March 26, 2025 10:43
@ovitrif ovitrif changed the title Cache balance and load on startup Cache balance and load it on startup Mar 26, 2025
Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the wallet has some logout flow? if yes, the balance should be cleared

@ovitrif
Copy link
Collaborator Author

ovitrif commented Mar 26, 2025

Does the wallet has some logout flow? if yes, the balance should be cleared

Yes, good point!

It should already happen, here:

https://github.com/synonymdev/bitkit-android/blob/master/app/src/main/java/to/bitkit/viewmodels/WalletViewModel.kt#L334-L336

@ovitrif ovitrif merged commit b96d7ec into master Mar 26, 2025
1 check passed
@ovitrif ovitrif deleted the feat/cache-balance branch March 26, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants