Implement editable BalanceHeader #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'm not fully satisfied with this solutions, but the bugs were solved. I'll think in more improvements |
ovitrif
reviewed
Apr 16, 2025
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
Great work! Added a few remarks.
Overall looks good, also very nice refactor in SendAmountScreen, kudos for doing it 🙌🏻
Biggest issues I noticed:
- styling of the large amount text needs polishing (*)
- the placeholders flashing when switching currencies
- small values change when switching currencies, ideally those would remain the same and re-converting would only happen when updating the input value.
* expected amount text style:
app/src/main/java/to/bitkit/ui/components/NumberPadTextField.kt
Outdated
Show resolved
Hide resolved
Member
Author
|
I still couldn't find a good way to prevent conversion when switching between BTC and fiat |
ovitrif
approved these changes
Apr 16, 2025
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
Nice progress 👏🏻 I think we can merge this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIGMA
Currently the BalanceHeaderView doesn't allow to set input in fiat
Reference
Related to #49
Closes #74
Screen_recording_20250416_120549.mp4