Skip to content

Conversation

@pwltr
Copy link
Contributor

@pwltr pwltr commented Dec 2, 2025

Description

  • add toast when switching currency for the first time
  • add toast when hiding balance for the first time

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.17.-.2025-12-02.at.19.38.04.mov

@pwltr
Copy link
Contributor Author

pwltr commented Dec 2, 2025

@piotr-iohk I think this needs to wait for the toast to hide:

[0-0] Error in "@settings - Settings.Security and Privacy.@settings_06 - Can swipe to hide balance"
Error: element ("~DrawerSettings") still not displayed after 30000ms
    at async tap (/Users/bitkit/bitkit-ios-runner/actions-runner/_work/bitkit-ios/bitkit-ios/bitkit-e2e-tests/test/helpers/actions.ts:243:3)
    at async <anonymous> (/Users/bitkit/bitkit-ios-runner/actions-runner/_work/bitkit-ios/bitkit-ios/bitkit-e2e-tests/test/specs/settings.e2e.ts:224:7)
    at async Context.<anonymous> (/Users/bitkit/bitkit-ios-runner/actions-runner/_work/bitkit-ios/bitkit-ios/bitkit-e2e-tests/test/helpers/suite.ts:29:5)

@piotr-iohk
Copy link
Collaborator

@pwltr there seems to be an issue introduced. "Hide balance on open" setting is not preserved.

Simulator.Screen.Recording.-.iPhone.17.-.2025-12-03.at.10.24.09.mov

@pwltr
Copy link
Contributor Author

pwltr commented Dec 3, 2025

@pwltr there seems to be an issue introduced. "Hide balance on open" setting is not preserved.

Simulator.Screen.Recording.-.iPhone.17.-.2025-12-03.at.10.24.09.mov

Hmm, works for me. Could be related to this: #246 I don't think it is caused by this PR. If you can please retest on master branch.

Simulator.Screen.Recording.-.iPhone.17.-.2025-12-03.at.10.41.28.mov

@piotr-iohk
Copy link
Collaborator

Hmm, works for me. Could be related to this: #246 I don't think it is caused by this PR. If you can please retest on master branch.

I can see it on master too indeed. Strange that it passed through e2e as one of the tests @settings_06 has this particular check and it is pretty much 100% reproducible for me. Anyway, I will create a bug ticket and disable this check in the test until the issue is addressed.

@pwltr pwltr merged commit 22f1542 into master Dec 3, 2025
23 of 28 checks passed
@pwltr pwltr deleted the feat/balance-toasts branch December 3, 2025 15:55
BitcoinErrorLog pushed a commit to BitcoinErrorLog/bitkit-ios that referenced this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants