refactor: move LSP balance calculations to BitkitCore #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsfer to spending flow
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors channel liquidity calculations by migrating core business logic from Swift to bitkit-core, consolidating balance calculations and improving UX with better loading states and form validation.
Key Changes:
- Migrated LSP balance calculations to bitkit-core's
calculateChannelLiquidityOptionsandgetDefaultLspBalancefunctions - Improved SpendingAmount view with proper loading indicators and disabled state validation
- Enhanced SpendingAdvancedView with task cancellation and proper async handling
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
Bitkit/Views/Transfer/SpendingAmount.swift |
Refactored max transfer amount calculation to use new bitkit-core functions, added loading states and validation |
Bitkit/Views/Transfer/SpendingAdvancedView.swift |
Added loading state, improved async task cancellation, and removed unused wallet dependency |
Bitkit/ViewModels/TransferViewModel.swift |
Replaced manual calculation logic with bitkit-core's calculateChannelLiquidityOptions function |
Bitkit/ViewModels/BlocktankViewModel.swift |
Migrated LSP balance calculation to use bitkit-core's getDefaultLspBalance function |
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved |
Updated bitkit-core package revision |
pwltr
requested changes
Dec 5, 2025
pwltr
approved these changes
Dec 5, 2025
Contributor
pwltr
left a comment
pwltr
left a comment
There was a problem hiding this comment.
LGTM, integration tests failing because of backend issue
BitcoinErrorLog
pushed a commit
to BitcoinErrorLog/bitkit-ios
that referenced
this pull request
Dec 15, 2025
* refactor: move LSP balance calculations to BitkitCore and improve transfer to spending flow * Fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors channel liquidity calculations from native app to bitkit-core and improves the spending flow limits and UX.
recording1.mp4