Update bitkit-core v0.1.33 and ldk-node v0.7.0-rc.1 #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ben-kaufman
commented
Dec 11, 2025
ben-kaufman
commented
- Fix duplicated tx received notifications by marking activity as seen
- Save tx details and fetch them from bitkit-core
- Update ldk-node to v0.7.0-rc.1
- Fix duplicated tx received notifications by marking activity as seen - Save tx details and fetch them from bitkit-core - Update ldk-node to v0.7.0-rc.1
ben-kaufman
force-pushed
the
update-bitkit-ldk-node-versions
branch
from
2287bb3 to
531ab1d
Compare
pwltr
approved these changes
Dec 11, 2025
Collaborator
Need this for Android too ❤️ , nice solution! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates dependencies (bitkit-core v0.1.33 and ldk-node v0.7.0-rc.1) and implements activity tracking improvements to prevent duplicate transaction received notifications. The changes include adding a seenAt field to activity records, storing transaction details in bitkit-core, and updating error handling for new ldk-node API patterns.
Key changes:
- Added
seenAttimestamp tracking to activity records to mark when users have seen notifications - Refactored transaction details storage from ldk-node to bitkit-core for persistence
- Updated ldk-node initialization to use new entropy setting pattern
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| BitkitTests/ActivityListTest.swift | Added seenAt: nil parameter to all test activity creation calls |
| Bitkit/Views/Wallets/Sheets/BoostSheet.swift | Added seenAt: nil parameter to test activity creation |
| Bitkit/Views/Wallets/Activity/ActivityItemView.swift | Added seenAt: nil parameter to preview activity creation |
| Bitkit/Views/Wallets/Activity/ActivityExplorerView.swift | Updated to fetch transaction details from CoreService instead of LightningService; added seenAt: nil to preview activities |
| Bitkit/Views/Gift/GiftLoading.swift | Added marking of gift receipt activity as seen before showing success sheet |
| Bitkit/ViewModels/AppViewModel.swift | Implemented seen status checking before showing received transaction sheets to prevent duplicates |
| Bitkit/Utilities/Errors.swift | Added new ldk-node error cases and reorganized error handling for BuildError |
| Bitkit/Services/LightningService.swift | Removed local transaction details method; updated to use new ldk-node entropy setting API |
| Bitkit/Services/CoreService.swift | Added comprehensive seen tracking functionality, transaction details mapping/storage, and updated to use BitkitCore.TransactionDetails type |
| Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved | Updated bitkit-core and ldk-node dependency revisions |
BitcoinErrorLog
pushed a commit
to BitcoinErrorLog/bitkit-ios
that referenced
this pull request
Dec 15, 2025
…ode-versions Update bitkit-core v0.1.33 and ldk-node v0.7.0-rc.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.