Fix/send manual entry #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns iOS send flow behavior with Bitkit's React Native/Android implementation by adding manual-entry invoice validation and enabling interactive editing from the review screen. The Continue button on manual entry is now gated on successful invoice decode, and users can tap the displayed invoice/address or amount on the review screen to edit them.
Key Changes:
- Manual-entry validation: Continue button is disabled until the entered address/invoice successfully decodes
- Review screen interactivity: Tapping the invoice/address opens the manual-entry editor, tapping the amount returns to the amount screen
- Amount preservation: Previously entered amounts are restored when navigating back to the amount screen
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
AppViewModel.swift |
Adds manual entry validation state (manualEntryInput, isManualEntryInputValid) and async validation logic with sequence-based debouncing |
SendEnterManuallyView.swift |
Implements validation-based Continue button gating using custom binding that triggers async validation on text changes |
SendConfirmationView.swift |
Makes invoice/address and amount displays tappable, adds navigation logic to return to manual entry or amount screens |
SendAmountView.swift |
Restores previously entered amount from wallet.sendAmountSats when navigating back to amount screen |
MoneyStack.swift |
Adds optional onTap callback parameter to support custom tap behavior instead of default currency toggle |
SendOptionsView.swift |
Resets manual entry input state when navigating to manual entry screen |
jvsena42
reviewed
Dec 15, 2025
jvsena42
approved these changes
Dec 15, 2025
Member
jvsena42
left a comment
jvsena42
left a comment
There was a problem hiding this comment.
Tested with valid and invalid parameters:
- Set Bip 21 manually
- Set bolt 11 manually
- Edit amount navigation
BitcoinErrorLog
pushed a commit
to BitcoinErrorLog/bitkit-ios
that referenced
this pull request
Dec 15, 2025
pwltr
reviewed
Dec 15, 2025
Comment on lines
+603
to
+611
| if let amountIndex = navigationPath.lastIndex(of: .amount) { | ||
| navigationPath = Array(navigationPath.prefix(amountIndex + 1)) | ||
| } else { | ||
| if let confirmIndex = navigationPath.lastIndex(of: .confirm) { | ||
| navigationPath = Array(navigationPath.prefix(confirmIndex)) | ||
| } | ||
| navigationPath.append(.amount) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
When paying a Lightning invoice with a fixed amount, it shouldn't be possible to change the amount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for the send e2e suite, this PR aligns iOS behavior with Bitkit RN/Android:
ReviewUri) opens the manual-entry editor, tapping the amount (ReviewAmount) returns to the amount screen with the previously entered sats.Linked Issues/Tasks
Screenshot / Video
Simulator.Screen.Recording.-.iPhone.17.-.2025-12-12.at.11.32.55.mov
Simulator.Screen.Recording.-.iPhone.17.-.2025-12-12.at.11.41.47.mov
Simulator.Screen.Recording.-.iPhone.17.-.2025-12-12.at.11.33.52.mov
Simulator.Screen.Recording.-.iPhone.17.-.2025-12-12.at.12.19.02.mov