Add Paykit integration module (Phase 2) #272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 14, 2025 17:47
- Document LightningService and CoreService integration points - Map Paykit executor methods to Bitkit APIs - Document async/sync bridging patterns - Document error handling and network configuration - Outline payment completion strategies - Document transaction details extraction approaches
Implements the core Paykit integration components: - PaykitManager: Singleton managing PaykitClient lifecycle and executor registration. Maps LDKNode.Network to Paykit network configs. - BitkitBitcoinExecutor: Implements BitcoinExecutorFFI, bridging Bitkit's LightningService.send(address:) to Paykit's onchain payment interface. Uses semaphore-based async-to-sync bridging. - BitkitLightningExecutor: Implements LightningExecutorFFI, bridging LightningService.send(bolt11:) to Paykit. Includes payment completion polling to extract preimage proof. - PaykitIntegrationHelper: Convenience methods for setup and payment execution, plus AsyncBridge utilities. Note: PaykitMobile bindings (UniFFI generated) must be linked before these components are fully functional. TODOs mark where binding code should be uncommented once available.
Contributor
Author
|
Opened in error - should be on fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the core Paykit integration module for Bitkit iOS:
PaykitManager: Singleton managing PaykitClient lifecycle and executor registration. Maps
LDKNode.Networkto Paykit network configs (mainnet/testnet/regtest/signet).BitkitBitcoinExecutor: Implements
BitcoinExecutorFFI, bridging Bitkit'sLightningService.send(address:)to Paykit's onchain payment interface. Uses semaphore-based async-to-sync bridging for FFI compatibility.BitkitLightningExecutor: Implements
LightningExecutorFFI, bridgingLightningService.send(bolt11:)to Paykit. Includes payment completion polling to extract preimage proof, SHA256 verification, and hex data handling.PaykitIntegrationHelper: Convenience methods for setup and payment execution, plus
AsyncBridgeutilities for sync/async bridging.Key Features
Env.networkto Paykit's network enumsPrerequisites
PaykitMobile UniFFI bindings must be generated and linked before these components are fully functional. TODOs in the code mark where binding code should be uncommented.
Test plan
cargo build --features mobilePaykitIntegrationHelper.setup()during app startup