-
Notifications
You must be signed in to change notification settings - Fork 1
chore: update env vars for mainnet #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
|
It seems that app produces addresses with mainnet HRP even on local regtest docker backend, so e2e tests complain: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Bitkit app configuration for Bitcoin mainnet deployment, refactors VSS client initialization, and updates the app icon. Key changes include switching the network configuration from regtest to mainnet, updating service URLs, adding proper network-specific keychain groups, and removing redundant VSS setup calls.
Key Changes
- Switched default network from regtest to Bitcoin mainnet with corresponding service URLs and trusted peers
- Consolidated environment variable logic with network-specific keychain groups
- Removed redundant VSS client setup calls (leverages lazy initialization)
Reviewed changes
Copilot reviewed 13 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Bitkit/Constants/Env.swift | Major refactor of environment configuration with mainnet URLs, network-specific keychain groups, and simplified server URL logic |
| BitkitNotification/BitkitNotification.entitlements | Added keychain access groups for different networks |
| Bitkit/Bitkit.entitlements | Added keychain access groups for different networks |
| Bitkit/Services/BackupService.swift | Removed redundant VSS client setup calls |
| Bitkit/Services/LightningService.swift | Refactored trusted peer configuration and added network graph logging |
| Bitkit/Services/CoreService.swift | Removed regtest-only restriction on activity removal |
| Bitkit/Utilities/AppReset.swift | Made log wiping conditional on regtest network |
| Bitkit/Views/Settings/LdkDebugScreen.swift | New debug screen for LDK operations |
| Bitkit/Views/Settings/DevSettingsView.swift | Added LDK debug option and reordered test notification button |
| Bitkit/ViewModels/NavigationViewModel.swift | Added ldkDebug route |
| Bitkit/MainNavView.swift | Added LdkDebugScreen to navigation |
| Bitkit/Views/Wallets/Activity/ActivityExplorerView.swift | Simplified block explorer URL generation |
| Bitkit/AppScene.swift | Improved error logging |
Comments suppressed due to low confidence (1)
Bitkit/Services/LightningService.swift:1
- The
isRestartingNodeflag is not reset to false in the success case if an error occurs. It should be set to false in a defer block or both success and error paths to ensure proper cleanup.
import BitkitCore
jvsena42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked:
- Create fresh wallet
- onchain Address creation
- Blocktank peers connection
- Backup status
Not checked:
- send and receive operations
OBS: Could update the Readme with instructions of how to build to different networks
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested send and receive LN on existing wallet from previous version of the branch, where I did my original mainnet iOS testing.
Approved but strongly backing @jvsena42 's suggestion to update README with info for building for the different networks.
|
Actually we can amend README after merge in another PR… |
Description