Skip to content

Conversation

@pwltr
Copy link
Contributor

@pwltr pwltr commented Dec 22, 2025

Description

  • update environment variables for Bitcoin mainnet
  • fix redundant setup calls for VSS client (it has lazy initialization when first backup is triggered)
  • update app icon

@pwltr pwltr requested review from ben-kaufman and ovitrif December 22, 2025 15:03
@piotr-iohk
Copy link
Collaborator

It seems that app produces addresses with mainnet HRP even on local regtest docker backend, so e2e tests complain:

Error: Invalid Bitcoin address: bc1qe986tzg5rx5ccgzrcdctgqzk68ctvshkme5msr

@jvsena42 jvsena42 requested a review from Copilot December 22, 2025 18:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Bitkit app configuration for Bitcoin mainnet deployment, refactors VSS client initialization, and updates the app icon. Key changes include switching the network configuration from regtest to mainnet, updating service URLs, adding proper network-specific keychain groups, and removing redundant VSS setup calls.

Key Changes

  • Switched default network from regtest to Bitcoin mainnet with corresponding service URLs and trusted peers
  • Consolidated environment variable logic with network-specific keychain groups
  • Removed redundant VSS client setup calls (leverages lazy initialization)

Reviewed changes

Copilot reviewed 13 out of 28 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Bitkit/Constants/Env.swift Major refactor of environment configuration with mainnet URLs, network-specific keychain groups, and simplified server URL logic
BitkitNotification/BitkitNotification.entitlements Added keychain access groups for different networks
Bitkit/Bitkit.entitlements Added keychain access groups for different networks
Bitkit/Services/BackupService.swift Removed redundant VSS client setup calls
Bitkit/Services/LightningService.swift Refactored trusted peer configuration and added network graph logging
Bitkit/Services/CoreService.swift Removed regtest-only restriction on activity removal
Bitkit/Utilities/AppReset.swift Made log wiping conditional on regtest network
Bitkit/Views/Settings/LdkDebugScreen.swift New debug screen for LDK operations
Bitkit/Views/Settings/DevSettingsView.swift Added LDK debug option and reordered test notification button
Bitkit/ViewModels/NavigationViewModel.swift Added ldkDebug route
Bitkit/MainNavView.swift Added LdkDebugScreen to navigation
Bitkit/Views/Wallets/Activity/ActivityExplorerView.swift Simplified block explorer URL generation
Bitkit/AppScene.swift Improved error logging
Comments suppressed due to low confidence (1)

Bitkit/Services/LightningService.swift:1

  • The isRestartingNode flag is not reset to false in the success case if an error occurs. It should be set to false in a defer block or both success and error paths to ensure proper cleanup.
import BitkitCore

Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked:

  • Create fresh wallet
  • onchain Address creation
  • Blocktank peers connection
  • Backup status

Not checked:

  • send and receive operations

OBS: Could update the Readme with instructions of how to build to different networks

Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested send and receive LN on existing wallet from previous version of the branch, where I did my original mainnet iOS testing.

Approved but strongly backing @jvsena42 's suggestion to update README with info for building for the different networks.

@ovitrif
Copy link
Collaborator

ovitrif commented Dec 23, 2025

Actually we can amend README after merge in another PR…

@ovitrif ovitrif merged commit 4a27a88 into master Dec 23, 2025
9 of 10 checks passed
@ovitrif ovitrif deleted the mainnet branch December 23, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants