Skip to content

Conversation

@pwltr
Copy link
Collaborator

@pwltr pwltr commented Dec 18, 2024

Description

Prerequisite for #2380

  • upgrade to react-navigation v7 & react-native-screens v4
  • refactor NavigationHeader to always popTo() top most screen in the stack
  • remove unused screens OpenConnectionSuccess

Follow migration steps from https://reactnavigation.org/docs/upgrading-from-6.x:

  • wrap all nested navigators in <NavigationIndependentTree />
  • use popTo() for back navigation

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

QA Notes

Make sure navigation, especially back and close buttons, works as expected.

@socket-security
Copy link

socket-security bot commented Dec 18, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@pwltr pwltr force-pushed the chore/update-nav-deps branch from 161ca76 to 7bcaa3f Compare December 18, 2024 18:38
@pwltr pwltr force-pushed the chore/update-nav-deps branch 2 times, most recently from 85ac376 to e9b43bc Compare December 19, 2024 11:40
@pwltr pwltr changed the title chore: upgrade nav dependencies refactor: upgrade nav dependencies Dec 19, 2024
@pwltr pwltr force-pushed the chore/update-nav-deps branch from e9b43bc to c5c3e71 Compare December 19, 2024 12:33
@pwltr pwltr requested a review from coreyphillips December 19, 2024 13:25
@pwltr pwltr merged commit 727174a into master Jan 1, 2025
7 checks passed
@pwltr pwltr deleted the chore/update-nav-deps branch January 1, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants