Merge pull request #14 from syntacore/aap-sc/ubsan_comparator_bsearch

aap-sc · web-flow · commit d003d077a24c · 2025-10-15T21:25:01.000+03:00
[cherry-pick] target/riscv: fix potential UB reported by ubsan in ac cache lookup
diff --git a/src/target/riscv/riscv-013.c b/src/target/riscv/riscv-013.c
@@ -201,6 +201,8 @@ static void ac_cache_insert(struct ac_cache *cache, uint32_t command)
 
 static bool ac_cache_contains(const struct ac_cache *cache, uint32_t command)
 {
+	if (cache->size == 0)
+		return false;
 	return bsearch(&command, cache->commands, cache->size,
 			sizeof(*cache->commands), ac_cache_elem_comparator);
 }

Original file line number	Diff line number	Diff line change
`@@ -201,6 +201,8 @@ static void ac_cache_insert(struct ac_cache *cache, uint32_t command)`
`201`	`201`
`202`	`202`	`static bool ac_cache_contains(const struct ac_cache *cache, uint32_t command)`
`203`	`203`	`{`
	`204`	`+ if (cache->size == 0)`
	`205`	`+ return false;`
`204`	`206`	`return bsearch(&command, cache->commands, cache->size,`
`205`	`207`	`sizeof(*cache->commands), ac_cache_elem_comparator);`
`206`	`208`	`}`