[snippy] Propagate mabi to target machine#408
Open
MaxGud10 wants to merge 1 commit intosyntacore:mainfrom
Open
[snippy] Propagate mabi to target machine#408MaxGud10 wants to merge 1 commit intosyntacore:mainfrom
MaxGud10 wants to merge 1 commit intosyntacore:mainfrom
Conversation
MaxGud10
changed the title
MaxGud10
force-pushed
the
fix-mabi-abi-in-elf
branch
from
8ca956e to
5863e94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20
Previously,
mabiwas stored in the configuration and emitted as a module flag,but it was not propagated to
TargetMachinecreation.As a result, the generated ELF ABI did not always match the requested
mabiunless the corresponding floating-point features were also forced through
mattr.This change passes
mabithroughTargetOptions::MCOptions.ABINamewhencreating the target machine and adds a regression test that checks the ELF
header flags for
lp64d.