-
Notifications
You must be signed in to change notification settings - Fork 2
Docs improvements #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,19 +40,14 @@ | |
| "source": [ | ||
| "Grids are handled using the `synthesizer.Grid` class, where the `grid_dir` argument tells the code where the desired Grid lives.\n", | ||
| "\n", | ||
| "Here is some code to download the grids using the `synthesizer-download` command." | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, | ||
| "id": "3bd60ad0", | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "Here is some code to download the grids using the `synthesizer-download` command.\n", | ||
| "\n", | ||
| "```python\n", | ||
| "\n", | ||
| "import subprocess\n", | ||
| "\n", | ||
| "subprocess.Popen([\"synthesizer-download\", \"--test-grids\", \"--dust-grid\"])" | ||
| "subprocess.Popen([\"synthesizer-download\", \"--test-grids\", \"--dust-grid\"])`\n", | ||
| "```" | ||
|
Comment on lines
+43
to
+50
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove stray backtick on line 49. Line 49 has a trailing backtick that should be removed. The line should end with just a closing parenthesis. Apply this diff: -subprocess.Popen(["synthesizer-download", "--test-grids", "--dust-grid"])`
+subprocess.Popen(["synthesizer-download", "--test-grids", "--dust-grid"])🤖 Prompt for AI Agents |
||
| ] | ||
| }, | ||
| { | ||
|
|
@@ -321,8 +316,8 @@ | |
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "from synthesizer.emission_models import Blackbody\n", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainVerify the simplified import path for Blackbody. The import has been updated to use the top-level package path, consistent with similar changes in other notebooks. Ensure that 🏁 Script executed: #!/bin/bash
# Check if Blackbody is available at the top-level emission_models module
rg -n "class Blackbody" --type=py -C2
rg -n "from.*Blackbody" --type=py -C2Length of output: 1080 Length of output: 29 Length of output: 0 Length of output: 205 Length of output: 503 Length of output: 1319 💡 Result: Use the dust emission module. Example: from synthesizer.emission_models.dust.emission import Blackbody then create one, e.g.:from unyt import K Sources: Synthesizer docs (dust emission examples). [1][2] Correct the import path to match the official Synthesizer package structure. The simplified import 🤖 Prompt for AI Agents |
||
| "from synthesizer.emission_models.attenuation import PowerLaw\n", | ||
| "from synthesizer.emission_models.dust.emission import Blackbody\n", | ||
| "\n", | ||
| "dust_curve = PowerLaw(slope=-0.7)\n", | ||
| "dust_emission_model = Blackbody(temperature=30 * Kelvin)" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify the simplified import path for Greybody.
The import has been updated to use the top-level package path. Ensure that
Greybodyis exported fromsynthesizer.emission_modelsand this import path is valid.🏁 Script executed:
Length of output: 3861
🏁 Script executed:
Length of output: 10609
🏁 Script executed:
Length of output: 148
🏁 Script executed:
Length of output: 3219
Length of output: 0
🏁 Script executed:
Length of output: 0
🏁 Script executed:
Length of output: 0
🏁 Script executed:
Length of output: 0
🏁 Script executed:
Length of output: 1341
🏁 Script executed:
Length of output: 0
🌐 Web query:
💡 Result:
Use the Greybody class from the dust emission module. Example import:
from synthesizer.emission_models.dust.emission import Greybody. [1][2]
References:
Fix the incorrect import path for Greybody.
The simplified import path
from synthesizer.emission_models import Greybodyis invalid. The correct import isfrom synthesizer.emission_models.dust.emission import Greybody, as confirmed by all example scripts in the codebase and official documentation. The notebook's current import will fail at runtime.Update line 25 to use the full module path matching the examples:
🤖 Prompt for AI Agents