Externalize React/ReactDOM and add en-US locale fallback to support Silverstripe 6#79
Open
tomstgeorge wants to merge 4 commits intosyntro-opensource:6from
Open
Externalize React/ReactDOM and add en-US locale fallback to support Silverstripe 6#79tomstgeorge wants to merge 4 commits intosyntro-opensource:6from
tomstgeorge wants to merge 4 commits intosyntro-opensource:6from
Conversation
…ta detection for SS6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves two critical issues that block the SEO module's analysis features in Silverstripe 6 environments.
The Problem
main.js. In Silverstripe 6 (React 18), this causes an "Invalid hook call" crash because the component tries to use a different React context than the one provided by the CMS admin.en-USLocale: The module hardcodes afallbackLng: 'en-US'ini18n.js, but the package only contained anenfolder, leading to 404 errors that prevent the analysis field from initializing.The Fix
webpack.config.jsto treatreact,react-dom, andreact-dom/clientas external dependencies.silverstripe-adminin SS6:react->Reactreact-dom->ReactDomreact-dom/client->ReactDomClienten-UStranslation files to the source to resolve 404 errors.main.jswith these mappings applied.Verification