-
-
Notifications
You must be signed in to change notification settings - Fork 472
Bump minimum required version to 3.10.0 #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the minimum required CMake version from 3.6 to 3.10.0 to address deprecation warnings about older CMake version support being removed in future releases.
- Updates CMake minimum version requirement to 3.10.0
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…with CMake < 3.10 will be removed from a future version of CMAKE'
679b50d to
454e3c3
Compare
|
@mwlasiuk Thanks! What is your system FYI?(e.g. Ubuntu 24.04) |
Tested on:
|
|
cmake 4.x is relatively new. |
|
I'd also love to see this fixed - the warning is really annoying 🙂 but I don't understand your need to wait until version 4 is mature - this change does not mandate a version higher than 3.10? |
|
For the record, passing |
Thanks for the tip! |
|
I would also like to be this PR merged. |
Bump minimum required version to 3.10.0.
After updating CMake on my system I was getting annoyed by warning that support for CMake < 3.10 will be removed in future version.