Skip to content

Conversation

@mwlasiuk
Copy link

Bump minimum required version to 3.10.0.

After updating CMake on my system I was getting annoyed by warning that support for CMake < 3.10 will be removed in future version.

@syoyo syoyo requested a review from Copilot August 19, 2025 18:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the minimum required CMake version from 3.6 to 3.10.0 to address deprecation warnings about older CMake version support being removed in future releases.

  • Updates CMake minimum version requirement to 3.10.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

…with CMake < 3.10 will be removed from a future version of CMAKE'
@mwlasiuk mwlasiuk force-pushed the mw/get-rid-of-cmake-warning branch from 679b50d to 454e3c3 Compare August 19, 2025 18:20
@syoyo
Copy link
Owner

syoyo commented Aug 20, 2025

@mwlasiuk Thanks! What is your system FYI?(e.g. Ubuntu 24.04)

@mwlasiuk
Copy link
Author

@mwlasiuk Thanks! What is your system FYI?(e.g. Ubuntu 24.04)

Tested on:

  • Ubuntu 24.04 LTS with CMake 4.1.0 and default CMake from apt
  • Ubuntu 11 WSL (Debian 12) with CMake 4.1.0 and default CMake from apt
  • Windows 11 with CMake 4.1.0-rc2

@syoyo
Copy link
Owner

syoyo commented Aug 21, 2025

cmake 4.x is relatively new.
I'd like to wait bumping cmake min version until cmake 4.x gets mature(2~3 years)

@jimarnold
Copy link

I'd also love to see this fixed - the warning is really annoying 🙂 but I don't understand your need to wait until version 4 is mature - this change does not mandate a version higher than 3.10?

@linkdd
Copy link

linkdd commented Oct 16, 2025

For the record, passing -DCMAKE_POLICY_VERSION_MINIMUM=3.10 to the cmake command forces the minimum version to 3.10, which removes the warning.

@jimarnold
Copy link

For the record, passing -DCMAKE_POLICY_VERSION_MINIMUM=3.10 to the cmake command forces the minimum version to 3.10, which removes the warning.

Thanks for the tip!

@alemuntoni
Copy link

I would also like to be this PR merged.
CMake now deafaults to 4.0 in a lot of package managers, and version 3.10 is reasonably old for minimum support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants